From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933051AbaGWTRd (ORCPT ); Wed, 23 Jul 2014 15:17:33 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:13507 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932514AbaGWTRc (ORCPT ); Wed, 23 Jul 2014 15:17:32 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 23 Jul 2014 12:09:37 -0700 Message-ID: <53D00A47.7050203@nvidia.com> Date: Wed, 23 Jul 2014 22:17:27 +0300 From: Tuomas Tynkkynen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Viresh Kumar CC: "linux-tegra@vger.kernel.org" , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , "linux-pm@vger.kernel.org" , Stephen Warren , Thierry Reding , Peter De Schrijver , Prashant Gaikwad , Mike Turquette , "Rafael J. Wysocki" , Paul Walmsley , "devicetree@vger.kernel.org" Subject: Re: [PATCH v2 14/16] cpufreq: Add cpufreq driver for Tegra124 References: <1405957142-19416-1-git-send-email-ttynkkynen@nvidia.com> <1405957142-19416-15-git-send-email-ttynkkynen@nvidia.com> <53CFA33F.6030307@nvidia.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/07/14 19:50, Viresh Kumar wrote: > On 23 July 2014 17:27, Tuomas Tynkkynen wrote: >> The platform device is required for the deferred probe that can happen if the >> DFLL driver hasn't initialized yet, and module_init() callbacks don't seem to >> respect -EPROBE_DEFER. > > Oh, which call in this file will return EPROBE_DEFER? I couldn't make out > which one will depend on DFLL driver. > It's this: +static int tegra124_cpufreq_probe(struct platform_device *pdev) +{ [...] + + dfll_clk = of_clk_get_by_name(cpu_dev->of_node, "dfll"); + if (IS_ERR(dfll_clk)) { + ret = PTR_ERR(dfll_clk); + goto out_put_cpu_clk; + } -- nvpublic