From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933602AbaGWVhE (ORCPT ); Wed, 23 Jul 2014 17:37:04 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:37487 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933386AbaGWVhB (ORCPT ); Wed, 23 Jul 2014 17:37:01 -0400 Message-ID: <53D02AF8.5000100@wwwdotorg.org> Date: Wed, 23 Jul 2014 15:36:56 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Dmitry Torokhov CC: nick.dyer@itdev.co.uk, Yufeng Shen , Daniel Kurtz , Henrik Rydberg , Joonyoung Shim , Alan Bowens , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Meerwald , Benson Leung , Olof Johansson , Sekhar Nori , Stephen Warren Subject: Re: [PATCH 04/15] Input: atmel_mxt_ts - implement device tree support References: <1404399697-26484-1-git-send-email-nick.dyer@itdev.co.uk> <1404399697-26484-5-git-send-email-nick.dyer@itdev.co.uk> In-Reply-To: <1404399697-26484-5-git-send-email-nick.dyer@itdev.co.uk> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/03/2014 09:01 AM, nick.dyer@itdev.co.uk wrote: > From: Stephen Warren > > Signed-off-by: Stephen Warren > Signed-off-by: Nick Dyer Hmm. It looks like the version of this patch that was actually applied varies quite a bit from what was posted, in particular in the implementation and call site of mxt_parse_dt(). It'd be nice if the commit log had been adjusted to mention this, so it didn't look like *I* caused all those compile errors and warnings that the 0-day builder just found:-(