From: "Andreas Färber" <afaerber@suse.de>
To: Doug Anderson <dianders@chromium.org>
Cc: linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Stephan van Schaik <stephan@synkhronix.com>,
Vincent Palatin <vpalatin@chromium.org>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
"moderated list:ARM/SAMSUNG ARM A..."
<linux-arm-kernel@lists.infradead.org>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] ARM: dts: exynos5250: Fold common ChromeOS parts into Snow
Date: Tue, 29 Jul 2014 14:45:37 +0200 [thread overview]
Message-ID: <53D79771.1020406@suse.de> (raw)
In-Reply-To: <CAD=FV=VK0KJknJ2099S7fEDzBnpPCrpSZ36WPkJB156GpcyEfg@mail.gmail.com>
Doug,
Am 25.07.2014 18:02, schrieb Doug Anderson:
> On Fri, Jul 18, 2014 at 10:20 AM, Andreas Färber <afaerber@suse.de> wrote:
>> +/*
>> + * On Snow we've got SIP WiFi and so can keep drive strengths low to
>> + * reduce EMI.
>> + */
>> +&mmc_3 {
>> + status = "okay";
>> + num-slots = <1>;
>> + supports-highspeed;
>> + broken-cd;
>> + card-detect-delay = <200>;
>> + samsung,dw-mshc-ciu-div = <3>;
>> + samsung,dw-mshc-sdr-timing = <2 3>;
>> + samsung,dw-mshc-ddr-timing = <1 2>;
>> +
>> + slot@0 {
>> + reg = <0>;
>> + bus-width = <4>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&sd3_clk &sd3_cmd &sd3_bus4>;
>
> This actually looks like a bug on snow. I don't think these pinctrl
> statements are taking effect and I think they belong at the mmc level,
> not the slot level. That's not a new bug introduced by you, though.
> Mind fixing it? You've already got it right for Spring mmc_1.
I was taught never to mix code movements with functional changes, as it
hides them even if mentioned in the commit message. Would you like me to
fix it pre- or post-move? Post-move would be easiest for me. ;)
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-07-29 12:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1405704009-8430-1-git-send-email-afaerber@suse.de>
2014-07-18 17:20 ` [PATCH v2 1/4] ARM: dts: exynos5250: max77686 is Snow only Andreas Färber
2014-07-25 5:28 ` Kukjin Kim
2014-07-25 15:08 ` Doug Anderson
2014-07-25 15:13 ` Doug Anderson
2014-07-25 15:30 ` Andreas Färber
2014-07-25 16:02 ` Doug Anderson
2014-07-29 16:15 ` Doug Anderson
2014-07-18 17:20 ` [PATCH v2 2/4] ARM: dts: exynos5250: cypress,cyapa trackpad " Andreas Färber
2014-07-29 16:16 ` Doug Anderson
2014-07-29 23:06 ` Kukjin Kim
2014-07-30 0:21 ` Andreas Färber
2014-07-18 17:20 ` [PATCH v2 3/4] ARM: dts: exynos5250: Fold common ChromeOS parts into Snow Andreas Färber
2014-07-25 16:02 ` Doug Anderson
2014-07-29 12:45 ` Andreas Färber [this message]
2014-07-29 15:11 ` Doug Anderson
2014-07-25 16:35 ` Javier Martinez Canillas
2014-07-25 16:43 ` Doug Anderson
2014-07-25 17:02 ` Javier Martinez Canillas
2014-07-29 13:00 ` Andreas Färber
2014-07-29 14:39 ` Javier Martinez Canillas
2014-07-29 15:27 ` Doug Anderson
2014-07-18 17:20 ` [PATCH v2 4/4] ARM: dts: exynos5250: Add Spring device tree Andreas Färber
2014-07-25 16:02 ` Doug Anderson
2014-07-30 13:06 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D79771.1020406@suse.de \
--to=afaerber@suse.de \
--cc=ben-linux@fluff.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=stephan@synkhronix.com \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).