From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
ivan.khoronzhuk@ti.com,
Muralidharan Karicheri <m-karicheri2@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Varka Bhadram <varkabhadram@gmail.com>
Subject: Re: [PATCH v2] gpio: keystone: add dsp gpio controller driver
Date: Mon, 11 Aug 2014 19:06:45 +0300 [thread overview]
Message-ID: <53E8EA15.2040003@ti.com> (raw)
In-Reply-To: <CACRpkdZAHj+PMu-xJJow+9ndbp9srnQtmb4E2k5x3nkaQA1jCg@mail.gmail.com>
Hi Linus,
On 08/08/2014 03:53 PM, Linus Walleij wrote:
> On Wed, Jul 23, 2014 at 4:44 PM, Grygorii Strashko
> <grygorii.strashko@ti.com> wrote:
>
>> From: Murali Karicheri <m-karicheri2@ti.com>
>>
>> On Keystone SOCs, ARM host can send interrupts to DSP cores using the
>> DSP GPIO controller IP. Each DSP GPIO controller provides 28 IRQ signals for
>> each DSP core. This is one of the component used by the IPC mechanism used
>> on Keystone SOCs.
>>
>> Keystone 2 DSP GPIO controller has specific features:
>> - each GPIO can be configured only as output pin;
>> - setting GPIO value to 1 causes IRQ generation on target DSP core;
>> - reading pin value returns 0 - if IRQ was handled or 1 - IRQ is still
>> pending.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>> Changes in v2:
>> - minor comments applied
>
> Hm so there was one major comment, quoting myself:
>
> "And if you proceed with this, please integrate it with
> drivers/gpio/gpio-syscon.c, I don't need more special
> syscons GPIO handlers."
>
> Maybe you missed this in the midst of the other discussions
> about whether this is GPIO at all, but that comment still
> stands even if you talk me down on the generality of this
> driver.
>
There is some misunderstanding, sorry.
And I've not missed your Major comment.
I posted v2 after a week after v1, but, unfortunately, right
before discussion on v1 had been actually started :(
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-keystone.txt
>
> Make this follow the style in:
> Documentation/devicetree/bindings/gpio/cirrus,clps711x-mctrl-gpio.txt
>
Regards,
-grygorii
prev parent reply other threads:[~2014-08-11 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 14:44 [PATCH v2] gpio: keystone: add dsp gpio controller driver Grygorii Strashko
2014-07-23 15:54 ` Varka Bhadram
2014-07-24 19:15 ` Suman Anna
2014-07-25 15:44 ` Grygorii Strashko
2014-08-08 12:53 ` Linus Walleij
2014-08-11 16:06 ` Grygorii Strashko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E8EA15.2040003@ti.com \
--to=grygorii.strashko@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ivan.khoronzhuk@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=robh+dt@kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).