From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
devel@driverdev.osuosl.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
John Stultz <john.stultz@linaro.org>,
Colin Cross <ccross@google.com>
Subject: Re: [PATCH 1/2] android: fix reference leak in sync_fence_create
Date: Mon, 18 Aug 2014 15:06:52 +0200 [thread overview]
Message-ID: <53F1FA6C.2030605@canonical.com> (raw)
In-Reply-To: <20140818125719.GA5423@mwanda>
Hey,
Op 18-08-14 om 14:57 schreef Dan Carpenter:
> On Thu, Aug 14, 2014 at 11:53:38AM +0200, Maarten Lankhorst wrote:
>> According to the documentation sync_fence_create takes ownership of the point,
>> not a reference on the point.
>>
> What are the user visible effects of this bug? I assume this is a real
> bug but judging solely based on your patch description, it sounds like
> you could just update the documentation instead of changing the code.
>
Small memory leak on every created android fence when you run out of tree android drivers.
But because it happens every frame (or possibly even more often) it's worth fixing.
~Maarten
prev parent reply other threads:[~2014-08-18 13:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 9:53 [PATCH 1/2] android: fix reference leak in sync_fence_create Maarten Lankhorst
2014-08-14 9:54 ` [PATCH 2/2] android: add sync_fence_create_dma Maarten Lankhorst
2014-08-14 20:09 ` Jesse Barnes
2014-08-15 6:46 ` Greg Kroah-Hartman
2014-08-15 16:23 ` Jesse Barnes
2014-08-28 6:54 ` Maarten Lankhorst
2014-08-28 11:57 ` Dan Carpenter
2014-09-01 12:33 ` Maarten Lankhorst
2014-09-01 12:45 ` Dan Carpenter
2014-08-18 12:57 ` [PATCH 1/2] android: fix reference leak in sync_fence_create Dan Carpenter
2014-08-18 13:06 ` Maarten Lankhorst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F1FA6C.2030605@canonical.com \
--to=maarten.lankhorst@canonical.com \
--cc=ccross@google.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel.vetter@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).