From: Hannes Reinecke <hare@suse.de>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
"James E.J. Bottomley" <JBottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: scsi: #define missing include guards
Date: Tue, 26 Aug 2014 11:26:55 +0200 [thread overview]
Message-ID: <53FC52DF.2000007@suse.de> (raw)
In-Reply-To: <1408711053-14129-1-git-send-email-linux@rasmusvillemoes.dk>
On 08/22/2014 02:37 PM, Rasmus Villemoes wrote:
> The four files aha1542.h, aha1740.h, gvp11.h and mvme147.h under
> drivers/scsi/ contain two-thirds of an include guard, but do not
> elsewhere.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/scsi/aha1542.h | 1 +
> drivers/scsi/aha1740.h | 1 +
> drivers/scsi/gvp11.h | 1 +
> drivers/scsi/mvme147.h | 1 +
> 4 files changed, 4 insertions(+)
>
> diff --git a/drivers/scsi/aha1542.h b/drivers/scsi/aha1542.h
> index b871d2b..8f4e07a 100644
> --- a/drivers/scsi/aha1542.h
> +++ b/drivers/scsi/aha1542.h
> @@ -1,4 +1,5 @@
> #ifndef _AHA1542_H
> +#define _AHA1542_H
>
> /* $Id: aha1542.h,v 1.1 1992/07/24 06:27:38 root Exp root $
> *
> diff --git a/drivers/scsi/aha1740.h b/drivers/scsi/aha1740.h
> index af23fd6..7ea484f 100644
> --- a/drivers/scsi/aha1740.h
> +++ b/drivers/scsi/aha1740.h
> @@ -1,4 +1,5 @@
> #ifndef _AHA1740_H
> +#define _AHA1740_H
>
> /* $Id$
> *
> diff --git a/drivers/scsi/gvp11.h b/drivers/scsi/gvp11.h
> index 852913c..5aabe90 100644
> --- a/drivers/scsi/gvp11.h
> +++ b/drivers/scsi/gvp11.h
> @@ -1,4 +1,5 @@
> #ifndef GVP11_H
> +#define GVP11_H
>
> /* $Id: gvp11.h,v 1.4 1997/01/19 23:07:12 davem Exp $
> *
> diff --git a/drivers/scsi/mvme147.h b/drivers/scsi/mvme147.h
> index bfd4566..479e9b4 100644
> --- a/drivers/scsi/mvme147.h
> +++ b/drivers/scsi/mvme147.h
> @@ -1,4 +1,5 @@
> #ifndef MVME147_H
> +#define MVME147_H
>
> /* $Id: mvme147.h,v 1.4 1997/01/19 23:07:10 davem Exp $
> *
>
Not that it matter much, but:
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
prev parent reply other threads:[~2014-08-26 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 12:37 [PATCH] drivers: scsi: #define missing include guards Rasmus Villemoes
2014-08-22 13:28 ` Rasmus Villemoes
2014-08-24 15:35 ` Christoph Hellwig
2014-08-25 8:10 ` [PATCH v2] " Rasmus Villemoes
2014-08-26 9:26 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC52DF.2000007@suse.de \
--to=hare@suse.de \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).