From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>, <santosh.shilimkar@ti.com>,
Jason Cooper <jason@lakedaemon.net>
Cc: Dan Carpenter <dan.carpenter@oracle.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqchip: keystone: remove warning unsigned 'kirq->irq' is never less than zero
Date: Thu, 28 Aug 2014 20:26:43 +0300 [thread overview]
Message-ID: <53FF6653.60802@ti.com> (raw)
In-Reply-To: <1409246189-29727-1-git-send-email-grygorii.strashko@ti.com>
Hi Jason,
On 08/28/2014 08:16 PM, Grygorii Strashko wrote:
> Remove static checker warning:
>
> drivers/irqchip/irq-keystone.c:166 keystone_irq_probe()
> warn: unsigned 'kirq->irq' is never less than zero.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
Sorry, forgot to mention that this is incremental fix for the patch
https://lkml.org/lkml/2014/7/23/891
"[PATCH v2] irqchip: add keystone irq controller ip driver" which is
in linux-next already.
> drivers/irqchip/irq-keystone.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-keystone.c b/drivers/irqchip/irq-keystone.c
> index fea26bc..608abf9 100644
> --- a/drivers/irqchip/irq-keystone.c
> +++ b/drivers/irqchip/irq-keystone.c
> @@ -36,7 +36,7 @@ struct keystone_irq_device {
> struct device *dev;
> struct irq_chip chip;
> u32 mask;
> - u32 irq;
> + int irq;
> struct irq_domain *irqd;
> struct regmap *devctrl_regs;
> u32 devctrl_offset;
>
next prev parent reply other threads:[~2014-08-28 17:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 14:40 [PATCH v2] irqchip: add keystone irq controller ip driver Grygorii Strashko
2014-07-23 15:32 ` Varka Bhadram
2014-07-23 18:01 ` Grygorii Strashko
2014-07-24 0:58 ` Varka Bhadram
2014-07-24 16:20 ` Grygorii Strashko
2014-08-17 19:39 ` Jason Cooper
2014-08-28 17:16 ` [PATCH] irqchip: keystone: remove warning unsigned 'kirq->irq' is never less than zero Grygorii Strashko
2014-08-28 17:26 ` Grygorii Strashko [this message]
2014-09-03 11:51 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FF6653.60802@ti.com \
--to=grygorii.strashko@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).