* [PATCH v2] iwlwifi: fix config variable name in comment
@ 2020-01-30 8:06 Luca Ceresoli
2020-01-30 8:54 ` Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: Luca Ceresoli @ 2020-01-30 8:06 UTC (permalink / raw)
To: linux-wireless
Cc: Luca Ceresoli, Luca Coelho, Johannes Berg, Emmanuel Grumbach,
Intel Linux Wireless, Kalle Valo, David S. Miller, netdev,
linux-kernel
The correct variable name was replaced here by mistake.
Fixes: ab27926d9e4a ("iwlwifi: fix devices with PCI Device ID 0x34F0 and 11ac RF modules")
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
Changes in v2:
- rebased on current master fixing conflicts
---
drivers/net/wireless/intel/iwlwifi/iwl-config.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-config.h b/drivers/net/wireless/intel/iwlwifi/iwl-config.h
index be6a2bf9ce74..df2d3257cce2 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-config.h
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-config.h
@@ -600,6 +600,6 @@ extern const struct iwl_cfg iwlax211_2ax_cfg_so_gf_a0;
extern const struct iwl_cfg iwlax210_2ax_cfg_ty_gf_a0;
extern const struct iwl_cfg iwlax411_2ax_cfg_so_gf4_a0;
extern const struct iwl_cfg iwlax411_2ax_cfg_sosnj_gf4_a0;
-#endif /* CPTCFG_IWLMVM || CPTCFG_IWLFMAC */
+#endif /* CONFIG_IWLMVM */
#endif /* __IWL_CONFIG_H__ */
--
2.25.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] iwlwifi: fix config variable name in comment
2020-01-30 8:06 [PATCH v2] iwlwifi: fix config variable name in comment Luca Ceresoli
@ 2020-01-30 8:54 ` Kalle Valo
2020-02-10 13:59 ` Luca Ceresoli
0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2020-01-30 8:54 UTC (permalink / raw)
To: Luca Ceresoli
Cc: linux-wireless, Luca Coelho, Johannes Berg, Emmanuel Grumbach,
Intel Linux Wireless, David S. Miller, netdev, linux-kernel
Luca Ceresoli <luca@lucaceresoli.net> writes:
> The correct variable name was replaced here by mistake.
>
> Fixes: ab27926d9e4a ("iwlwifi: fix devices with PCI Device ID 0x34F0
> and 11ac RF modules")
The Fixes tag should be all in one line. But TBH I'm not sure if it
makes sense to add that to a patch which has no functional changes like
this one.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] iwlwifi: fix config variable name in comment
2020-01-30 8:54 ` Kalle Valo
@ 2020-02-10 13:59 ` Luca Ceresoli
0 siblings, 0 replies; 3+ messages in thread
From: Luca Ceresoli @ 2020-02-10 13:59 UTC (permalink / raw)
To: Kalle Valo
Cc: linux-wireless, Luca Coelho, Johannes Berg, Emmanuel Grumbach,
Intel Linux Wireless, David S. Miller, netdev, linux-kernel
Hi Kalle,
On 30/01/20 09:54, Kalle Valo wrote:
> Luca Ceresoli <luca@lucaceresoli.net> writes:
>
>> The correct variable name was replaced here by mistake.
>>
>> Fixes: ab27926d9e4a ("iwlwifi: fix devices with PCI Device ID 0x34F0
>> and 11ac RF modules")
>
> The Fixes tag should be all in one line. But TBH I'm not sure if it
> makes sense to add that to a patch which has no functional changes like
> this one.
Ok, I agree this is a gray area. Just sent v3 without the Fixes tag.
Thanks,
--
Luca
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-10 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-30 8:06 [PATCH v2] iwlwifi: fix config variable name in comment Luca Ceresoli
2020-01-30 8:54 ` Kalle Valo
2020-02-10 13:59 ` Luca Ceresoli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).