From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FC7CC433EF for ; Fri, 22 Jul 2022 18:19:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235812AbiGVSTg (ORCPT ); Fri, 22 Jul 2022 14:19:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231304AbiGVSTe (ORCPT ); Fri, 22 Jul 2022 14:19:34 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB10D6EEAA for ; Fri, 22 Jul 2022 11:19:32 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id a10so6370839ljj.5 for ; Fri, 22 Jul 2022 11:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=TZ89NCSHpZWO6mCiLEkZnsSyxqredp26c+bp6T/IeXs=; b=HV2GeR6BqM1M0qBzVbeUKHIw4fCOt3RQzgcGZy1wqC6IiFpuwgMNPkh0g8Y/uMaKAH OPH5AMoUcrCuZ6YLo/Ab1VxkoWQukq698ETcZCSPIdkWcbq7JYIwN09+aApa4lzffA9r Bw0mz0Yow33Ut9oatcpEWxyS+qJOZ72yMzlMiouUcy9oQKS1QsCrYtji9b/rl0THTVQT gbbAeLCjm0RHR6pxJwZ5uSbTWJuCDhIPDo94gY67qTUO6epy3MqdVwzFgzLqGdvyxe1v zHDpKFnIKu4CeGxT84s6GCq3UWLhF70ryWeBAW99BThs4Eg8r1rw/tlGkerAtRCAgo88 k0MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=TZ89NCSHpZWO6mCiLEkZnsSyxqredp26c+bp6T/IeXs=; b=ZERWg7kJeYNSF9GMiiWqxDKgQ7G42gmbj0cnRhcWnTAP3l9ffWtkMO1kZ7kcg+Efb7 efzuP19PKDl2cAaZF5JrSSko2FNjvw507ruaWnb/NUbNJPJRk33GNR9zYRs9gIIxJ3iR u8h6y9wFzeLgXiO9Sy+QO9YkJDGOw84ZG/9abQfC6nSajf59GrAMOZBDyPb7vhMzKtbt aRgbydhP6Vs8rCm+bAjF6kqWd1BTiJHauxjX/JGFTF5eYwyQ9nvveE+tJ128cnL96a6v Cx53MtKhHDkcB55Jtx0qkMG8i5E9qXggHwrqw+/tg/QQyV+3XCFHuLnTP1+HYIG9WAvH jo+g== X-Gm-Message-State: AJIora/sv0vCqIy7bdTuL7+EAlhIWWCF4fGh84S89Y0pQ/orfD5ds73X CWr9NnSVmts288fixXilddOL0A== X-Google-Smtp-Source: AGRyM1t9k6EuxFUL5jwICaF3I0/coOUkurh+jWMFDTooiNiiyxUpIROwoEbytIQYZDtIHnlMr6Elbg== X-Received: by 2002:a2e:3209:0:b0:25d:644e:b9d4 with SMTP id y9-20020a2e3209000000b0025d644eb9d4mr401270ljy.13.1658513971230; Fri, 22 Jul 2022 11:19:31 -0700 (PDT) Received: from [192.168.10.173] (93.81-167-86.customer.lyse.net. [81.167.86.93]) by smtp.gmail.com with ESMTPSA id k2-20020a2ea262000000b0025d75995a07sm1259660ljm.24.2022.07.22.11.19.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 11:19:30 -0700 (PDT) Message-ID: <53d432e9-6715-05c4-d258-896ec38afa4f@linaro.org> Date: Fri, 22 Jul 2022 20:19:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/3] dt-bindings: mediatek: add pinctrl definition for mt8188 Content-Language: en-US To: "hui.liu" , linus.walleij@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com Cc: johnson.wang@mediatek.com, zhiyong.tao@mediatek.com, sean.wang@mediatek.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220718113813.23787-1-hui.liu@mediatek.com> <20220718113813.23787-2-hui.liu@mediatek.com> <08a7209fe198839093b3ef729fc97c1a950e1fbc.camel@mediatek.com> <35639a59-4a3d-5aa7-946c-22fbd2f25e89@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/07/2022 03:40, hui.liu wrote: > Hi, Krzysztof > > That's the comment about reg and reg-names description: >>> + reg: >>> + description: | >>> + Physical address base for gpio base registers. There are 8 >>> GPIO >>> + physical address base in mt8188. >> >> Redundant description, skip it. You should list the instead and >> describe >> each of it. >> >>> + maxItems: 8 >>> + >>> + reg-names: >>> + description: | >>> + Gpio base register names. >> >> Redundant description, skip it. >> >>> + maxItems: 8 >> >> You need to list the items instead. > > I plan to update reg and reg-names as the following: > reg: > description: | > Physical address base for gpio base registers. There are 6 > different GPIO physical address bases in mt8188. > minItems: 6 > maxItems: 6 You should rather have here items with description: items: - description: what is it - description: what is it .... > > reg-names: > items: > - const: iocfg0 > - const: iocfg_rm > - const: iocfg_lt > - const: iocfg_lm > - const: iocfg_rt > - const: eint > > Is it right? > > Thanks. > Best regards, Krzysztof