From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB6F4C43331 for ; Fri, 3 Apr 2020 11:57:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80FF42082F for ; Fri, 3 Apr 2020 11:57:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=tessares-net.20150623.gappssmtp.com header.i=@tessares-net.20150623.gappssmtp.com header.b="mP38Zims" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390890AbgDCL5y (ORCPT ); Fri, 3 Apr 2020 07:57:54 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:35438 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390800AbgDCL5x (ORCPT ); Fri, 3 Apr 2020 07:57:53 -0400 Received: by mail-wr1-f68.google.com with SMTP id g3so5893080wrx.2 for ; Fri, 03 Apr 2020 04:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=m9uB8CXOauOvkixvQHaupaJsW5GE1b/+9MUTIoEBWtw=; b=mP38ZimsazJj47mkB31YHkndHlq8nfBVb0VJ4dOpLB1q02Anbk8BAxgjDFiejLpnHc rwrkB8j9Ri1rZpdgetcOhGIrErQrE8HS53Tc8hrHbMxCFkFdzjDNitVYbsfim78ihOaZ u4JXfGcv+zQ6ADmmgT6EM3TsniIsxAe8eIq3s6BHW36VkRoeZi/BnDeDpbJR0wA6T9nM wjHXfO42JkRWkcSVAoutvrdb0l7R6+wwlv9p8XJLiMrt6UfCYL6EgjNlnxtAOyKXoVcD yl6PhQA4ps0zd3OTsyunfNULVHwRJJeNSQH1Kp0DOLP5LLjllmUh4sxz6+8dau9mK36g FmiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=m9uB8CXOauOvkixvQHaupaJsW5GE1b/+9MUTIoEBWtw=; b=PzH/zDLako3y/uhtn73+TMgANm/OZIS/ygyF45MreLwF2DRRNRK8i88hzZ+UigDKY1 mBf+JUH+CctVoD+psYHYUbGnLo3+yFvaK5tS5POkALTmsEojJxJ6vJGKBSEDvCD3yRrw 6t29bDZGlG24Q4CJFQRYtsMYHzIwU0XTfMPg4Q3R/g1wC5tte5H8VITqCDWlAHYrMknw tNDJmX3tLVeedk22dQ+zpM5KYo8JPYjg7uVu7cksYHmgNpWvUmIATrpwiZvMMJS9tR0R Z5ZTDcylHwNy2UO9ecQ7hJhgWfC8elPvnV5CQ14OV3Sv4kbSIveVdRAKBaziY2bYp7Du p8pg== X-Gm-Message-State: AGi0PuYjs0ljxRr5k0F4ht6CsKnC/O0FvMcqTU9Yftf97vrHgSUbTwiJ 39tBwUWBakuByTW92Jtyzh3wP92ciqRlLw== X-Google-Smtp-Source: APiQypKPqO12YqzsS7Yog6MXPvcZfc7I526z0zAxC3kpVH3jFAjLrqtwuG8Dx+nbJb1IWqQgbkC7Aw== X-Received: by 2002:adf:82a6:: with SMTP id 35mr8735769wrc.307.1585915070364; Fri, 03 Apr 2020 04:57:50 -0700 (PDT) Received: from tsr-lap-08.nix.tessares.net ([79.132.236.184]) by smtp.gmail.com with ESMTPSA id h26sm10928350wmb.19.2020.04.03.04.57.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 04:57:49 -0700 (PDT) Subject: Re: [PATCH v2] mptcp: add some missing pr_fmt defines To: Geliang Tang , Mat Martineau , "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org References: From: Matthieu Baerts Message-ID: <53e4271f-c881-c52d-c6e1-4930a4f6898a@tessares.net> Date: Fri, 3 Apr 2020 13:57:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geliang, On 03/04/2020 11:14, Geliang Tang wrote: > Some of the mptcp logs didn't print out the format string: > > [ 185.651493] DSS > [ 185.651494] data_fin=0 dsn64=0 use_map=0 ack64=1 use_ack=1 > [ 185.651494] data_ack=13792750332298763796 > [ 185.651495] MPTCP: msk=00000000c4b81cfc ssk=000000009743af53 data_avail=0 skb=0000000063dc595d > [ 185.651495] MPTCP: msk=00000000c4b81cfc ssk=000000009743af53 status=0 > [ 185.651495] MPTCP: msk ack_seq=9bbc894565aa2f9a subflow ack_seq=9bbc894565aa2f9a > [ 185.651496] MPTCP: msk=00000000c4b81cfc ssk=000000009743af53 data_avail=1 skb=0000000012e809e1 > > So this patch added these missing pr_fmt defines. Then we can get the same > format string "MPTCP" in all mptcp logs like this: > > [ 142.795829] MPTCP: DSS > [ 142.795829] MPTCP: data_fin=0 dsn64=0 use_map=0 ack64=1 use_ack=1 > [ 142.795829] MPTCP: data_ack=8089704603109242421 > [ 142.795830] MPTCP: msk=00000000133a24e0 ssk=000000002e508c64 data_avail=0 skb=00000000d5f230df > [ 142.795830] MPTCP: msk=00000000133a24e0 ssk=000000002e508c64 status=0 > [ 142.795831] MPTCP: msk ack_seq=66790290f1199d9b subflow ack_seq=66790290f1199d9b > [ 142.795831] MPTCP: msk=00000000133a24e0 ssk=000000002e508c64 data_avail=1 skb=00000000de5aca2e > > Signed-off-by: Geliang Tang > > --- > Changes in v2: > - add pr_fmt to C files, not headers. Thank you for this v2 (sorry, it was in my spam folder). I thought checkpatch.pl would have forced you to add a new blank line in net/mptcp/pm.c after the copyright comment and before the beginning of the code but it seems not. And there was no blank line before so I guess it's OK like that! Reviewed-by: Matthieu Baerts