From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 822C6ECE599 for ; Wed, 16 Oct 2019 20:14:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 532BE21925 for ; Wed, 16 Oct 2019 20:14:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WIUbKfkX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394701AbfJPUOM (ORCPT ); Wed, 16 Oct 2019 16:14:12 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:46288 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727796AbfJPUOM (ORCPT ); Wed, 16 Oct 2019 16:14:12 -0400 Received: by mail-lf1-f65.google.com with SMTP id t8so18483722lfc.13; Wed, 16 Oct 2019 13:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=l8ORRK6Z/tj+ennQWyvTLEJTSnUGYUzseJnIAFJK54Y=; b=WIUbKfkXB4bVekL2BhsU6rbjzRPObA8ejEHTjr3PD5CNbirFmMWzYqgPe6CWX7VhBH P2nIu3x9UdtBoeXpOhkL6h5FxrmlivAOUVg+UVXdnjf8747OaJHzP31eTNHDbJyCmvUF Vv5RAwio9wOy01S4tQkrPlueSoPxgbOQRqd22RjL85D2Xq8DAqKUMlPQngAIYcYshUqX 3/tv1MjZG061TU60EE5QsDs9ryn2uGImGZDhZkQiPrPrSy4ehG38kkmNoXgeaiFJAkFt quVJPwfmyg509ZkHJAu5lja8z42HohChbqlKUm/cvOMavHkMFB/XXP14ntD7D9AQx6u1 PdoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=l8ORRK6Z/tj+ennQWyvTLEJTSnUGYUzseJnIAFJK54Y=; b=Zo8l0w3C90qRD1CzYcSO2XTsGwRPdGZfMmXMhCQ9xfPT6JWyaXIQpMg5MV2kjusGkU otelJg8ikvhX6seqtI1IcRfBo3PwVKf+LQQlxU1tDr8ByzC0IK5DrhJGORqaJYhF6gzw e8/Gew6pLIqA16XhG+gpgRsh7vXufh23FyBC0v9aeb6XhrwGw+e9mIoj0ho47KIXJUAL hDXpMJaiTsYvqrtO0YAgZU/67eWKXk8vUFvEFVlP16enFtiwOenRaAgeOFwK3IR+UxIy 52Znpw/ozKRRdnF1jOna32sS7Nu0oDJaF6r2JeVDbkZGsTvUcxpD1WnZ6Dz83HXVhKSk v+GQ== X-Gm-Message-State: APjAAAX0qoDxJ0yNVIq7MiG0hwRMQFoooj4jgJjdQeuPrO+1EEAYYDt9 lTKTfV3bh9VmbVSdjeUfXedFsxTn X-Google-Smtp-Source: APXvYqz7gf96qvageIl96eIHyaGg0JllPJJaszitr7b0cxr6gT0o6PK4A+iEn9lyZdRx58b286zm2g== X-Received: by 2002:a19:6759:: with SMTP id e25mr6031339lfj.80.1571256849142; Wed, 16 Oct 2019 13:14:09 -0700 (PDT) Received: from [192.168.2.145] ([94.29.10.250]) by smtp.googlemail.com with ESMTPSA id 21sm6420332ljq.15.2019.10.16.13.14.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2019 13:14:08 -0700 (PDT) Subject: Re: [PATCH v6 00/18] Consolidate and improve NVIDIA Tegra CPUIDLE driver(s) From: Dmitry Osipenko To: Peter De Schrijver Cc: Thierry Reding , Jonathan Hunter , "Rafael J. Wysocki" , Daniel Lezcano , linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191015170015.1135-1-digetx@gmail.com> <20191016192133.GB26038@pdeschrijver-desktop.Nvidia.com> <72636eb3-5354-eea3-3a51-4975a04186b2@gmail.com> Message-ID: <53ee8bd3-5c53-f0aa-175c-7fa3024d0af5@gmail.com> Date: Wed, 16 Oct 2019 23:14:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <72636eb3-5354-eea3-3a51-4975a04186b2@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 16.10.2019 22:47, Dmitry Osipenko пишет: > 16.10.2019 22:21, Peter De Schrijver пишет: >> On Tue, Oct 15, 2019 at 07:59:57PM +0300, Dmitry Osipenko wrote: >>> Hello, >>> >>> This series does the following: >>> >>> 1. Unifies Tegra20/30/114 drivers into a single driver and moves it out >>> into common drivers/cpuidle/ directory. >>> >>> 2. Enables CPU cluster power-down idling state on Tegra30. >>> >>> In the end there is a quite nice clean up of the Tegra CPUIDLE drivers >>> and of the Tegra's arch code in general. Please review, thanks! >>> >>> Changelog: >>> >>> v6: - Addressed request from Thierry Reding to change the way patches are >>> organized by making changes in a more incremental manner. >>> >>> - tegra_sleep_cpu() now checks for the secondary CPUs to be offline >>> in the "Make outer_disable() open-coded" patch. >>> >>> v5: - Rebased on a recent linux-next, fixed one minor conflict in Kconfig. >>> >>> - Improved commit's message of the "Support CPU cluster power-down state >>> on Tegra30" patch. >>> >>> - The "Support CPU cluster power-down state on Tegra30" patch is also >>> got split and now there is additional "Make outer_disable() open-coded" >>> patch. >>> >>> - Made minor cosmetic changes to the "Introduce unified driver for >>> NVIDIA Tegra SoCs" patch by improving error message and renaming >>> one variable. >>> >>> v4: - Fixed compilation with !CONFIG_CACHE_L2X0 (and tested that it still >>> works). >>> >>> - Replaced ktime_compare() with ktime_before() in the new driver, >>> for consistency. >>> >>> v3: - Addressed review comments that were made by Jon Hunter to v2 by >>> splitting patches into smaller (and simpler) chunks, better >>> documenting changes in the commit messages and using proper error >>> codes in the code. >>> >>> Warnings are replaced with a useful error messages in the code of >>> "Introduce unified driver for NVIDIA Tegra SoCs" patch. >>> >>> Secondary CPUs parking timeout increased to 100ms because I found >>> that it actually may happen to take more than 1ms if CPU is running >>> on a *very* low frequency. >>> >>> Added diagnostic messages that are reporting Flow Controller state >>> when CPU parking fails. >>> >>> Further polished cpuidle driver's code. >>> >>> The coupled state entering is now aborted if there is a pending SGI >>> (Software Generated Interrupt) because it will be lost after GIC's >>> power-cycling. Like it was done by the old Tegra20 CPUIDLE driver. >>> >>> v2: - Added patches to enable the new cpuidle driver in the defconfigs: >>> >>> ARM: multi_v7_defconfig: Enable Tegra cpuidle driver >>> ARM: tegra: Enable Tegra cpuidle driver in tegra_defconfig >>> >>> - Dropped patches that removed CPUIDLE_FLAG_TIMER_STOP from the idling >>> states because that flag actually doesn't have any negative effects, >>> but still is correct for the case of a local CPU timer on older Tegra >>> SoCs: >>> >>> cpuidle: tegra: Remove CPUIDLE_FLAG_TIMER_STOP from Tegra114/124 idle-state >>> cpuidle: tegra: Remove CPUIDLE_FLAG_TIMER_STOP from all states >>> >>> - The "Add unified driver for NVIDIA Tegra SoCs" patch got more polish. >>> Tegra30 and Terga114 states are now squashed into a single common C7 >>> state (following Parker TRM terminology, see 17.2.2.2 Power Management >>> States), more comments added, etc minor changes. >> >> It would be useful to switch the power state terminology to the one used >> for later chips: >> >> LP0 becomes SC7 >> LP1 becomes C1 >> LP2 becomes CC7 >> >> Meaning of these states is as follows >> >> C is a core state: >> >> C1 clock gating >> C2 not defined >> C3 not defined >> C4 not defined >> C5 not defined >> C6 not defined for ARM cores >> C7 power-gating >> >> CC is a CPU cluster C state: >> >> CC1 cluster clock gated >> CC2 not defined >> CC3 fmax@Vmin: not used prior to Tegra186 >> CC4: cluster retention: no longer supported >> CC5: not defined >> CC6: cluster power gating >> CC7: cluster rail gating >> >> SC is a System C state: >> >> SC1: not defined >> SC2: not defined >> SC3: not defined >> SC4: not defined >> SC5: not defined >> SC6: not defined >> SC7: VDD_SOC off > > Hello Peter, > > But new "drivers/cpuidle/cpuidle-tegra.c" uses exactly that terminology, > please see "cpuidle: Refactor and move NVIDIA Tegra20 driver into > drivers/cpuidle/" and further patches. Am I missing something? Or do you > want the renaming to be a separate patch? > Or maybe you're suggesting to change the names everywhere and not only in the cpuidle driver? Please clarify :)