From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
SoC Team <soc@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Marek Vasut <marex@denx.de>,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
Etienne Carriere <etienne.carriere@st.com>
Subject: Re: [PATCH 2/8] dt-bindings: clock: stm32mp1: describes clocks if "st,stm32mp1-rcc-secure"
Date: Mon, 9 May 2022 14:55:55 +0200 [thread overview]
Message-ID: <53f8547c-70f9-139e-68f0-21298fa06ccf@foss.st.com> (raw)
In-Reply-To: <CAL_JsqKfA1joqDiophO4qk0S1XfgxE2EWUBrxqXrGdfjOAe=ew@mail.gmail.com>
On 5/9/22 14:36, Rob Herring wrote:
> On Fri, May 6, 2022 at 11:21 AM Rob Herring <robh+dt@kernel.org> wrote:
>>
>> On Fri, May 6, 2022 at 5:02 AM Alexandre TORGUE
>> <alexandre.torgue@foss.st.com> wrote:
>>>
>>> Hi Rob
>>>
>>> On 5/5/22 16:11, Rob Herring wrote:
>>>> On Fri, Apr 22, 2022 at 10:10 AM Alexandre Torgue
>>>> <alexandre.torgue@foss.st.com> wrote:
>>>>>
>>>>> In case of "st,stm32mp1-rcc-secure" (stm32mp1 clock driver with RCC
>>>>> security support hardened), "clocks" and "clock-names" describe oscillators
>>>>> and are required.
>>>>>
>>>>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>>>
>>>> This is now failing in linux-next:
>>>>
>>>> make[1]: *** Deleting file
>>>> 'Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dts'
>>>> Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml: found
>>>> duplicate key "clocks" with value "{}" (original value: "True")
>>>> make[1]: *** [Documentation/devicetree/bindings/Makefile:26:
>>>> Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dts]
>>>> Error 1
>>>> ./Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml:64:3:
>>>> [error] duplication of key "clocks" in mapping (key-duplicates)
>>>> ./Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml:69:3:
>>>> [error] duplication of key "clock-names" in mapping (key-duplicates)
>>>> Traceback (most recent call last):
>>>> File "/usr/local/bin/dt-doc-validate", line 25, in check_doc
>>>> testtree = dtschema.load(filename, line_number=line_number)
>>>> File "/usr/local/lib/python3.10/dist-packages/dtschema/lib.py", line
>>>> 914, in load
>>>> return yaml.load(f.read())
>>>> File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/main.py",
>>>> line 434, in load
>>>> return constructor.get_single_data()
>>>> File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/constructor.py",
>>>> line 121, in get_single_data
>>>> return self.construct_document(node)
>>>> File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/constructor.py",
>>>> line 131, in construct_document
>>>> for _dummy in generator:
>>>> File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/constructor.py",
>>>> line 674, in construct_yaml_map
>>>> value = self.construct_mapping(node)
>>>> File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/constructor.py",
>>>> line 445, in construct_mapping
>>>> return BaseConstructor.construct_mapping(self, node, deep=deep)
>>>> File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/constructor.py",
>>>> line 263, in construct_mapping
>>>> if self.check_mapping_key(node, key_node, mapping, key, value):
>>>> File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/constructor.py",
>>>> line 294, in check_mapping_key
>>>> raise DuplicateKeyError(*args)
>>>> ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping
>>>> in "<unicode string>", line 49, column 3
>>>> found duplicate key "clocks" with value "{}" (original value: "True")
>>>> in "<unicode string>", line 64, column 3
>>>> To suppress this check see:
>>>> http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys
>>>> During handling of the above exception, another exception occurred:
>>>> Traceback (most recent call last):
>>>> File "/usr/local/bin/dt-doc-validate", line 74, in <module>
>>>> ret = check_doc(f)
>>>> File "/usr/local/bin/dt-doc-validate", line 30, in check_doc
>>>> print(filename + ":", exc.path[-1], exc.message, file=sys.stderr)
>>>> AttributeError: 'DuplicateKeyError' object has no attribute 'path'
>>>
>>> It seems that we have a merge issue between:
>>>
>>> patch "dt-bindings: rcc: Add optional external ethernet RX clock properties"
>>> https://lore.kernel.org/r/20220410220514.21779-1-marex@denx.de
>>>
>>> and this one (dt-bindings: clock: stm32mp1: describes clocks if
>>> "st,stm32mp1-rcc-secure)
>>>
>>> On linux-next following part remains and creates issue above:
>>>
>>> clocks:
>>> description:
>>> Specifies the external RX clock for ethernet MAC.
>>> maxItems: 1
>>>
>>> clock-names:
>>> const: ETH_RX_CLK/ETH_REF_CLK
>>>
>>> I don't know why this part is remaining. In my tree, I took care to take
>>> Marek patch first to avoid this kind of issue.
>>>
>>> Btw, how to fix that ?
>>
>> Looks like I applied "dt-bindings: rcc: Add optional external ethernet
>> RX clock properties" too. I've reverted it in my tree.
>
> Now with it reverted in today's next:
>
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dtb:
> rcc@50000000: 'clocks' is a required property
> From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dtb:
> rcc@50000000: 'clock-names' is a required property
> From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
>
> The example needs updating.
Sure, I send an update.
Alex
>
> Rob
next prev parent reply other threads:[~2022-05-09 12:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 15:09 [PATCH 0/8] Add SCMI version of ST boards Alexandre Torgue
2022-04-22 15:09 ` [PATCH 1/8] dt-bindings: rcc: Add optional external ethernet RX clock properties Alexandre Torgue
2022-04-22 16:28 ` Marek Vasut
2022-04-25 17:21 ` Alexandre TORGUE
2022-04-22 15:09 ` [PATCH 2/8] dt-bindings: clock: stm32mp1: describes clocks if "st,stm32mp1-rcc-secure" Alexandre Torgue
2022-04-22 16:31 ` Marek Vasut
2022-04-25 19:11 ` Rob Herring
2022-04-25 19:35 ` Marek Vasut
2022-04-26 18:44 ` Rob Herring
2022-05-02 21:13 ` Rob Herring
[not found] ` <CAL_JsqKU28BNrozg20_a_XMUmBhaoDHdodWkzyRoH=VcM2pDjg@mail.gmail.com>
2022-05-06 10:02 ` Alexandre TORGUE
[not found] ` <CAL_JsqK5ox681qQFz6b4a8eSaNHJ08XmB2bTE=EZ2Pch0YDJqA@mail.gmail.com>
[not found] ` <CAL_JsqKfA1joqDiophO4qk0S1XfgxE2EWUBrxqXrGdfjOAe=ew@mail.gmail.com>
2022-05-09 12:55 ` Alexandre TORGUE [this message]
2022-04-22 15:09 ` [PATCH 3/8] dt-bindings: clock: stm32mp15: rename CK_SCMI define Alexandre Torgue
2022-05-02 21:26 ` Rob Herring
2022-04-22 15:09 ` [PATCH 4/8] dt-bindings: reset: stm32mp15: rename RST_SCMI define Alexandre Torgue
2022-05-02 21:27 ` Rob Herring
2022-04-22 15:09 ` [PATCH 5/8] ARM: stm32: select OPTEE on MPU family Alexandre Torgue
2022-04-22 15:37 ` Ahmad Fatoum
2022-04-22 16:23 ` Alexandre TORGUE
2022-04-22 15:09 ` [PATCH 6/8] ARM: dts: stm32: enable optee firmware and SCMI support on STM32MP15 Alexandre Torgue
2022-04-22 16:32 ` Marek Vasut
2022-04-25 10:19 ` Etienne CARRIERE
2022-04-25 10:25 ` Marek Vasut
2022-04-25 10:30 ` Rouven Czerwinski
2022-04-22 15:09 ` [PATCH 7/8] dt-bindings: arm: stm32: Add SCMI version of STM32 boards (DK1/DK2/ED1/EV1) Alexandre Torgue
2022-05-02 21:28 ` Rob Herring
2022-04-22 15:09 ` [PATCH 8/8] ARM: dts: " Alexandre Torgue
2022-05-03 14:51 ` [PATCH 0/8] Add SCMI version of ST boards Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53f8547c-70f9-139e-68f0-21298fa06ccf@foss.st.com \
--to=alexandre.torgue@foss.st.com \
--cc=a.fatoum@pengutronix.de \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=etienne.carriere@st.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marex@denx.de \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).