From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Rob Herring <robh@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Linus Walleij <linus.walleij@linaro.org>,
- <patches@opensource.cirrus.com>
Cc: "Rafał Miłecki" <rafal@milecki.pl>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: mfd: Fix pinctrl node name warnings
Date: Fri, 4 Mar 2022 08:31:28 +0100 [thread overview]
Message-ID: <53fbfcde-0f5e-8ea2-4bca-c7a414f96c57@canonical.com> (raw)
In-Reply-To: <20220303232350.2591143-1-robh@kernel.org>
On 04/03/2022 00:23, Rob Herring wrote:
> The recent addition pinctrl.yaml in commit c09acbc499e8 ("dt-bindings:
> pinctrl: use pinctrl.yaml") resulted in some node name warnings:
>
> Documentation/devicetree/bindings/mfd/cirrus,lochnagar.example.dt.yaml: \
> lochnagar-pinctrl: $nodename:0: 'lochnagar-pinctrl' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
> Documentation/devicetree/bindings/mfd/cirrus,madera.example.dt.yaml: \
> codec@1a: $nodename:0: 'codec@1a' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
> Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml: \
> pin-controller@1c0: $nodename:0: 'pin-controller@1c0' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
>
> Fix the node names to the preferred 'pinctrl'. For cirrus,madera,
> nothing from pinctrl.yaml schema is used, so just drop the reference.
>
> Fixes: c09acbc499e8 ("dt-bindings: pinctrl: use pinctrl.yaml")
> Cc: Rafał Miłecki <rafal@milecki.pl>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Fix lochnagar-pinctrl nodename in example
> v3:
> - And fix lochnagar-pinctrl nodename in 'required'. Sigh...
> ---
> Documentation/devicetree/bindings/mfd/brcm,cru.yaml | 4 ++--
> Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml | 6 +++---
> .../devicetree/bindings/pinctrl/cirrus,madera.yaml | 3 ---
> 3 files changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/brcm,cru.yaml b/Documentation/devicetree/bindings/mfd/brcm,cru.yaml
> index be4a2df71c25..b85819fbb07c 100644
> --- a/Documentation/devicetree/bindings/mfd/brcm,cru.yaml
> +++ b/Documentation/devicetree/bindings/mfd/brcm,cru.yaml
> @@ -39,7 +39,7 @@ patternProperties:
> '^phy@[a-f0-9]+$':
> $ref: ../phy/bcm-ns-usb2-phy.yaml
>
> - '^pin-controller@[a-f0-9]+$':
> + '^pinctrl@[a-f0-9]+$':
> $ref: ../pinctrl/brcm,ns-pinmux.yaml
>
> '^syscon@[a-f0-9]+$':
> @@ -94,7 +94,7 @@ examples:
> reg = <0x180 0x4>;
> };
>
> - pin-controller@1c0 {
> + pinctrl@1c0 {
DTS also need such change.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-04 7:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 23:23 [PATCH v3] dt-bindings: mfd: Fix pinctrl node name warnings Rob Herring
2022-03-04 7:31 ` Krzysztof Kozlowski [this message]
2022-03-04 9:59 ` Charles Keepax
2022-03-14 23:17 ` Linus Walleij
2022-03-22 7:27 ` Lee Jones
2022-03-23 14:37 ` Rob Herring
2022-03-23 14:46 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53fbfcde-0f5e-8ea2-4bca-c7a414f96c57@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rafal@milecki.pl \
--cc=rf@opensource.cirrus.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).