From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 533BFC43334 for ; Tue, 7 Jun 2022 11:16:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242678AbiFGLQG (ORCPT ); Tue, 7 Jun 2022 07:16:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242659AbiFGLP4 (ORCPT ); Tue, 7 Jun 2022 07:15:56 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2A425F91 for ; Tue, 7 Jun 2022 04:15:54 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id bg6so14665437ejb.0 for ; Tue, 07 Jun 2022 04:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=4fN31emiPSLrSSZpsn7Oq3o1ezw79oaA/r4pVULki3E=; b=tQY36N5MGuxHc3V9UqHKQuIQQ4aHKA7oOVp5CmeU6mfN4lFe6xAQF6cnDBGT7nlERl wTa7UnZ6mu1DqWXYcGvbyypxI0R7TzsEwcMvyfMZwho4d49acw9GDBbI/Ib3Dp5DAhv/ oqkSNaEGkV4YgLbLwJq3cQuvi//h1J2gZqMFgRt059TK+OAn35WnJOChAayryzg1nh23 nEQkAP4sQ3o0UxRLEUpEuDJWdZrRj7jwl+r72lvtEXSvExcM2vvzsW+AGxWZ1OkWAOTy YDcaC1JYUEZH2HMLiPU+0cPodpOEdnmvJTbSDTL8nKRwGO+dguWJGv8NDn3/ncuBTPkp yB+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=4fN31emiPSLrSSZpsn7Oq3o1ezw79oaA/r4pVULki3E=; b=T04vfRbA/2BLT80AduExmqHnrQNFLKgHu68N4qrfVYp41+zaWhjmuplMnFcKz2UcGb y2PExFsDgcCfGo1A+ARYzMqWtGausFX8w52p4uM5/8xM7LdhOa6gN3soRlVpk2ICiYI1 CBBCPucjxmNZ8ZTtzYvRHs1WTsy71O7TmLNyVDrx2UVj8gEqepMsBKz3i2es/Ou+vk1i BQuXhBmh88Whhe7JD2SpkOCZghyBi1Ah9VhXyCeWFA1PSxWf59rb/RLriYzFQBLNs7ge Jh/dIc9TgVAlIyxW0udtnYGDU/S2u5Q6RZz7VDGfaA+huAkwvTfZdfzaBQ9IsPI178h0 /IZw== X-Gm-Message-State: AOAM530AbEVDeGqvldgXQoE9XmwJP/wILyyilPo9zPmGllljaCZlD/ne /9CF00IoYJ3uZw+HLeOT8VWLJA== X-Google-Smtp-Source: ABdhPJzSEMUZJ83C9YuQS9zQGX+1xBdQyT2SxdNEMEw0D4djkDKkCIanjUa1Ek6Lg3gxSg/s6asbZw== X-Received: by 2002:a17:907:2cc3:b0:6f8:5a21:4d62 with SMTP id hg3-20020a1709072cc300b006f85a214d62mr27126205ejc.256.1654600553287; Tue, 07 Jun 2022 04:15:53 -0700 (PDT) Received: from [192.168.0.183] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id u15-20020a05640207cf00b0042dd60352d1sm10203839edy.35.2022.06.07.04.15.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 04:15:52 -0700 (PDT) Message-ID: <54015d41-d4eb-12ae-5bd1-00d2c3cf7814@linaro.org> Date: Tue, 7 Jun 2022 13:15:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/4] dt-bindings: arm: qcom: document qcom,msm-id and qcom,board-id Content-Language: en-US To: Rob Herring Cc: Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd , Konrad Dybcio , Amit Pundir , Trilok Soni , Rob Clark , Stephan Gerhold , Kumar Gala References: <20220529202629.47588-1-krzysztof.kozlowski@linaro.org> <20220529202629.47588-2-krzysztof.kozlowski@linaro.org> <20220605150747.GA3465286-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220605150747.GA3465286-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2022 17:07, Rob Herring wrote: > On Sun, May 29, 2022 at 10:26:26PM +0200, Krzysztof Kozlowski wrote: >> The top level qcom,msm-id and qcom,board-id properties are utilized by >> bootloaders on Qualcomm MSM platforms to determine which device tree >> should be used and passed to the kernel. >> >> The commit b32e592d3c28 ("devicetree: bindings: Document qcom board >> compatible format") from 2015 was a consensus during discussion about >> upstreaming qcom,msm-id and qcom,board-id fields. There are however still >> problems with that consensus: >> 1. It was reached 7 years ago but it turned out its implementation did >> not reach all possible products. >> >> 2. Initially additional tool (dtbTool) was needed for parsing these >> fields to create a QCDT image consisting of multiple DTBs, later the >> bootloaders were improved and they use these qcom,msm-id and >> qcom,board-id properties directly. >> >> 3. Extracting relevant information from the board compatible requires >> this additional tool (dtbTool), which makes the build process more >> complicated and not easily reproducible (DTBs are modified after the >> kernel build). >> >> 4. Some versions of Qualcomm bootloaders expect these properties even >> when booting with a single DTB. The community is stuck with these >> bootloaders thus they require properties in the DTBs. >> >> Since several upstreamed Qualcomm SoC-based boards require these >> properties to properly boot and the properties are reportedly used by >> bootloaders, document them. > > My primary issue here is accepting this will be an endorsement for > other vendors doing something similar. I'm not against an ID > property(ies) in the root node, but would rather see something common > if we do anything. Hi Rob, A more common approach was merged back in 2015 - encoding this ID information in the board compatibles. If I understood previous discussion correctly, this common method was later used by Qualcomm DTB post-processing tool. At least for some of the cases. Other cases (several Qualcomm boards from different vendors) still use these ID properties. It even turns out they use it differently between vendors (e.g. Xiaomi vs OnePlus). Important arguments for documenting these properties: 1. These ID properties are already on released boards where changing bootloader is non-trivial or even not possible. It will not be possible to remove these properties, without seriously affecting the community working with them. 2. According to Konrad [1] (second paragraph), newer chipsets (starting with sm8350 released in 2021) do not use these properties. These newer DTS do not have them. Considering 1+2 above, maybe let's document these properties as compatible? Would that solve your point of "endorsement for other vendors"? [1] https://lore.kernel.org/all/20220522195138.35943-1-konrad.dybcio@somainline.org/ Best regards, Krzysztof