From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>
Cc: Jagan Teki <jagan@amarulasolutions.com>,
Mark Rutland <mark.rutland@arm.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Akash Gajjar <akash@openedev.com>, Tom Cubie <tom@radxa.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-amarula@amarulasolutions.com
Subject: Re: [PATCH v2 1/5] dt-bindings: arm: rockchip: Add VMARC RK3399Pro SOM binding
Date: Wed, 04 Dec 2019 21:14:46 +0100 [thread overview]
Message-ID: <5408424.xnnVrITuBQ@diego> (raw)
In-Reply-To: <20191204193240.GA6772@bogus>
Am Mittwoch, 4. Dezember 2019, 20:32:40 CET schrieb Rob Herring:
> On Thu, Nov 21, 2019 at 07:44:41PM +0530, Jagan Teki wrote:
> > VMARC RK3399Pro SOM is a standard SMARC SOM design with
> > Rockchip RK3399Pro SoC, which is designed by Vamrs.
> >
> > Since it is a standard SMARC design, it can be easily
> > mounted on the supporting Carrier board. Radxa has
> > suitable carrier board to mount and use it as a final
> > version board.
> >
> > Add dt-bindings for it.
> >
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > Changes for v2:
> > - none
> >
> > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > index 45728fd22af8..51aa458833a9 100644
> > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > @@ -526,4 +526,9 @@ properties:
> > items:
> > - const: tronsmart,orion-r68-meta
> > - const: rockchip,rk3368
> > +
> > + - description: Vamrs VMARC RK3399Pro SOM
> > + items:
> > + - const: vamrs,rk3399pro-vmarc-som
>
> Why do you need this? You just override it in your dts files, so it is
> not really used. Perhaps the top-level should have all 3 compatibles? If
> so, then the schemas are wrong.
In the past we had SOMs that _could_ function alone, but looking at the
announcement for this one [0] suggests that the SOM always needs a carrier
board, so I don't think the SOM actually needs a separate entry but instead
should be part of the carrier-board compatible list, as Rob suggested.
So I guess we should only have (from patch 3):
- description: Radxa ROCK Pi N10
items:
- const: radxa,rockpi-n10
- const: vamrs,rk3399pro-vmarc-som
- const: rockchip,rk3399pro
Heiko
[0] https://www.96rocks.com/blog/2019/09/11/introduce-vamrc-rk3399pro-som-and-ficus2-carrier-board/
next prev parent reply other threads:[~2019-12-04 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 14:14 [PATCH v2 0/5] arm64: dts: rockchip: Add Rock Pi N10 support Jagan Teki
2019-11-21 14:14 ` [PATCH v2 1/5] dt-bindings: arm: rockchip: Add VMARC RK3399Pro SOM binding Jagan Teki
2019-12-04 19:32 ` Rob Herring
2019-12-04 20:14 ` Heiko Stübner [this message]
2019-11-21 14:14 ` [PATCH v2 2/5] arm64: dts: rockchip: Add VMARC RK3399Pro SOM initial support Jagan Teki
2019-11-21 14:14 ` [PATCH v2 3/5] dt-bindings: arm: rockchip: Add Rock Pi N10 binding Jagan Teki
2019-11-21 14:14 ` [PATCH v2 4/5] ARM: dts: rockchip: Add Radxa Dalang Carrier board Jagan Teki
2019-11-21 14:14 ` [PATCH v2 5/5] arm64: dts: rockchip: Add Radxa Rock Pi N10 initial support Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5408424.xnnVrITuBQ@diego \
--to=heiko@sntech.de \
--cc=akash@openedev.com \
--cc=devicetree@vger.kernel.org \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=tom@radxa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).