From: Ian Abbott <abbotti@mev.co.uk>
To: Hartley Sweeten <HartleyS@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "driverdev-devel@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: comedi: amplc_pci230: fix DACOUT write
Date: Tue, 9 Sep 2014 11:33:56 +0100 [thread overview]
Message-ID: <540ED794.5020701@mev.co.uk> (raw)
In-Reply-To: <DC148C5AA1CEBA4E87973D432B1C2D8825F903DB@P3PWEX4MB008.ex4.secureserver.net>
On 2014-09-08 20:34, Hartley Sweeten wrote:
> On Monday, September 08, 2014 12:15 PM, Greg Kroah-Hartman wrote:
>> On Tue, Aug 19, 2014 at 12:32:36PM +0100, Ian Abbott wrote:
>>> Commit 4f9c63fe5333b27ab23ed399830c7977f6970744 ("staging: comedi:
>>> amplc_pci230: refactor iobase addresses") removed some parentheses
>>> (presumably to keep the line withing 80 chars) in
>>> `pci230_ao_write_nofifo()` when writing to the DACOUT1 or DACOUT2
>>> registers, but it removed the wrong parentheses. Fix it.
>>>
>>> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
>>> ---
>>> This bug is in linux-next master and staging-next.
>>> ---
>>> drivers/staging/comedi/drivers/amplc_pci230.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c b/drivers/staging/comedi/drivers/amplc_pci230.c
>>> index 0fd212f..dd69e47 100644
>>> --- a/drivers/staging/comedi/drivers/amplc_pci230.c
>>> +++ b/drivers/staging/comedi/drivers/amplc_pci230.c
>>> @@ -628,7 +628,7 @@ static inline void pci230_ao_write_nofifo(struct comedi_device *dev,
>>>
>>> /* Write mangled datum to appropriate DACOUT register. */
>>> outw(pci230_ao_mangle_datum(dev, datum),
>>> - devpriv->daqio + ((chan) == 0) ? PCI230_DACOUT1 : PCI230_DACOUT2);
>>> + devpriv->daqio + (chan == 0 ? PCI230_DACOUT1 : PCI230_DACOUT2));
>>> }
>>>
>>> static inline void pci230_ao_write_fifo(struct comedi_device *dev,
>>> --
>>> 2.0.4
>>
>> This doesn't apply to my tree anymore, is it still needed?
>
> Looks like you already applied a similar patch from Dan Carpenter:
>
> commit 94254d1baec765b22cc5df3a9a16a8cc9a79d406
> Author: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Tue Aug 26 10:55:51 2014 +0300
>
> staging: comedi: amplc_pci230: fix a precedence bug
No, it's no longer needed.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2014-09-09 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 11:32 [PATCH] staging: comedi: amplc_pci230: fix DACOUT write Ian Abbott
2014-09-08 19:14 ` Greg Kroah-Hartman
2014-09-08 19:34 ` Hartley Sweeten
2014-09-09 10:33 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540ED794.5020701@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=HartleyS@visionengravers.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).