Re: [PATCHSET 0/5 v2] brd: partition fixes

From: Jens Axboe <axboe@fb.com>
To: Boaz Harrosh <boaz@plexistor.com>,
	Matthew Wilcox <willy@linux.intel.com>,
	Dmitry Monakhov <dmonakhov@openvz.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCHSET 0/5 v2] brd: partition fixes
Date: Tue, 9 Sep 2014 08:25:35 -0600	[thread overview]
Message-ID: <540F0DDF.3010907@fb.com> (raw)
In-Reply-To: <540EEE2C.1090801@plexistor.com>

On 09/09/2014 06:10 AM, Boaz Harrosh wrote:
> On 09/01/2014 01:15 PM, Boaz Harrosh wrote:
>> On 08/27/2014 06:22 PM, Boaz Harrosh wrote:
>>> Jens Hi
>>>
>>> What do you intend to do with these fixes? These are real bugs on devices
>>> shipped for a while now. I think they need to go into current 3.17-rcX Kernel.
>>>
>>
>> Jens hi
>>
>> I have seen that the brd patch went into rc3.
>>
>> I should insist then, that these patches go into this rc cycle ASAP.
>> For one they fix real *hard* unexpected bugs with brd that make it trash data.
>>
>> But specially because the patch to brd that just went into Kernel introduces
>> a wrong module parameter "show_part" which must be removed. If we release a Kernel
>> with it, it will be pain, we will need to deprecate it which is long and annoying
>> procedure. It is wrong because it must be always on. Pleas see below
>>
>> This patchset is based on what just went into Kernel.
>> Also on git here: git://git.open-osd.org/pmem.git brd-partitions branch
>>
>> [https://urldefense.proofpoint.com/v1/url?u=http://git.open-osd.org/gitweb.cgi?p%3Dpmem.git%3Ba%3Dshortlog%3Bh%3Drefs/heads/brd-partitions&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=3JMVyziIyZtZ5cv9eWNLwQ%3D%3D%0A&m=XOvuGmlhiuRy6LRMabkkeXBBXOBMB9BXeBpwsjyR98Y%3D%0A&s=c5919437c1a82b2bf63f9ca95ae6d96ebf2f0fbc2ed85bb6766df0add4af40b3]
>>
>> Thanks
>> Boaz
>>
> <>
>>> list of patches:
>>> [PATCH 1/5] axonram: Fix bug in direct_access
>>> [PATCH 2/5] Change direct_access calling convention
> <>
>>> [PATCH 3/5] brd: Add getgeo to block ops
> <>
>>> [PATCH 4/5] brd: Fix all partitions BUGs
>>> [PATCH 5/5] brd: Request from fdisk 4k alignment
> 
> Ping Jens?
> 
> Please tell me what you want to do with these patches. They must go into this Kernel
> cycle before brd is released with wrong user-mode visible nub
> 
> If you want you can drop the [PATCH 3/5] which is not important and can go in next
> cycle, but the others are real BUG fixes.

I will drop the 3/5 patch (do that one separately) and queue up and test.

-- 
Jens Axboe