From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752892AbcIIJK1 (ORCPT ); Fri, 9 Sep 2016 05:10:27 -0400 Received: from mail-by2nam01on0042.outbound.protection.outlook.com ([104.47.34.42]:39296 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750908AbcIIJKV (ORCPT ); Fri, 9 Sep 2016 05:10:21 -0400 X-Greylist: delayed 9239 seconds by postgrey-1.27 at vger.kernel.org; Fri, 09 Sep 2016 05:10:20 EDT Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH v6 1/2] sdhci-of-arasan: Add device tree parameter xlnx-fails-without-test-cd bit References: <1473363766-12652-1-git-send-email-zach.brown@ni.com> To: Zach Brown , CC: , , , , , , , , From: Michal Simek Message-ID: <541103ba-28d1-1fc0-cc5e-66eea914aa2d@xilinx.com> Date: Fri, 9 Sep 2016 08:36:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473363766-12652-1-git-send-email-zach.brown@ni.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22560.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(199003)(189002)(24454002)(9786002)(86362001)(92566002)(50466002)(65826007)(64126003)(626004)(81166006)(189998001)(31686004)(47776003)(19580395003)(8936002)(36386004)(5001770100001)(15975445007)(81156014)(19300405004)(11100500001)(83506001)(230700001)(23746002)(4001350100001)(33646002)(5660300001)(77096005)(2950100001)(586003)(230783001)(7846002)(106466001)(4326007)(36756003)(87936001)(356003)(19580405001)(2906002)(76176999)(65956001)(63266004)(31696002)(8676002)(65806001)(50986999)(54356999)(305945005)(107986001)(562404015);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0201MB0921;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT003;1:6x0mTTeNqRSb/Ze85/Wkgbn1RAYRWr1CuJjJdnXyjbzEgJ/RAY9FmsI1vsTIZvTuVm95wwomhkZekAGeYsB28CMv+nghpskXf6YU3IGle/IaSXqO+mHlAXy4hYxPQVlhdrOhgTb86FNovqrOoWg2b/U3l4ZemZ45EcP/1Kn7GeE+Nl/Wx2uND/54lzPeHdkvXw9keSUkRQUfbgQlpl8KONTSgnMBGrUQ8AJyMpD9ZyYpRaxqVGVXFCmgf7OslSi5k3H0kTmYaJIAVFB0wweWafM1a3TS1idUIq4hGHoJk3uk79g/2ol4ZtB8sJ467jpFUf3IJ4mtvGja4/2N/GZMP/f6pN/d2hpJygQAXJdtyH0liUAY/4JXdDdDsEkgWJJIMyldipGTBhX2+CNyblkUU+4WaqCJCieY5JpdLeZoxskPRje72La7TK6KDILejsp9WBQARlzGNCqpg2uCVjuwtxBwVg+pV/l+zSojcMNfauS/puANP1NnA/PeTIMgn1tHA6zlShRpLdFoQHisYGsWoentMxXJQ4G4eAVO7Udq2pXaeiAzJAkJmiz9TF9FEgfhHqN1AowazfDzAcDlv0rCswEZXGrS0nsxRxLPmuU7Y9Y= X-MS-Office365-Filtering-Correlation-Id: 4580cdd4-08a5-41b8-6117-08d3d87b9ba2 X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB0921;2:msvMIfch3tSXLTBrdEBI8TFhEiY/4H8vDNlEr8jfK7/JnQ5vUU0HX7vWvEG5oAxEYRvchBFktDv/jfd+nfVD1hddpjwtyCWDwJOhMTD+aD45Qvps3OV5Rj8ibuVKtpndq2tf3IZUBOR2sbO0EEdXun8cbac/qLYpYfRYpqDYxiF4DTxa6yn2OrGBDXc8pRZB;3:6nlg7KchRm2qGE2MqebNeIcECFlWoDmSZYLLq0CJaWEarhYhjQ+MixiBCR9cpSpisB62v+1BOykEOiX3tTI0ZG3avHuIEb5jF18pT9K865rUYdOiN6f7fC6UmX3BgT8ah3+f7Kxs1KYWblv1rS/txw9vbaaVyUkYNlN8iJPRusPk6O+J/a3FOA6J/TxIddWaAghyncsF1Zc4ikTh+aHQzdxb8Ix/1XUAtIabQM1/GGL8yXl01nSWeO5HPKgEIrOxybj+4UNz7oqQ02Ph3ZHkhw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:CY1PR0201MB0921; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB0921;25:NeZa0j2gV7t/mjlqiYeE8SWzjdjCENR1VW8lqyyP1vmGzMPS1yqGifJ/qxEQUDtLhNvXbgIfaKe1R2syzUbVEHSNOcwCzAVxKHj4Zie2Pk3SUtiny/bvxuGDLOJtbYmAJhmDbCFoe2e41yRzfCIXifH7hPHO7M6jCei3PPlE1pkTYELfhmGqlkFwM94zF+gG3ykS6SI0j/9F55AiT9YXDedSoU0CETB+57iw4f6viQWFc5tXXJjcFA66u44jiaEJKzIC3lOvoG+atX/V41Ywy+zyhU5otPrg7Vx2IFvktRgXwi02MH6cf41tnPAjmd27SN8RSBwcRlg68ECA+NarJlzpVeIUnJlb+k2znHHvdt/gFQdj7IB4eIuyoePU8WBerh6FpbMHEKkyo/6iPSDv6ok8FmQimmsbyzXNXLlqgAeCpAM0mVIhQf3Xu2n785kgfltTcFEgzeVGtbTtXb3NMkqkuHok70rbSbuPzWY+ZV31ydMsB8C2myscUg3fe9AQel4qy9KL8+xOvH6aU3SMdikNubLIYdw6rtMJ2YejHMSrzZcSQLy3irj4IFKIggSotj5kj1PAQyzxJNlzwt3tpfH8LFMAuq+9Wc6O4wFdl/92azVLo51sK7pXiOgek4EWCpTQEjAdfA5rPCOykeVf1JqUZLcs89MCPssgB255Q5V98tdsjvK+Zp1TuCcBELDOtKKnmE6x+puRzQ1siJd35rP6kuQ+30a9Vo6HQWDmeZDr7HFCBF6k1NcKdcygfkpGXnp3uW65MNJr4RBUmcwBnah71eKIp8T128IVyYzjnohLJY+/2x2DhQEYuuvd2K22KisNXpXIEhb9zZlSdi781wQvvhJ6N9lZ5FUw5RHjOa+h5X63ZeNA55f0iY5JXZmt X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB0921;31:LiSn6r7PFyxH+1ZL6usaPHtOxBLZUbRRpbWyXP1G7PvxvC9uvJae0x75SPhYznuZ85DpWjXC0Bw4mXuii6X2AQssyja1vaU2EjaTDEF+amJkjVPZIi1F9/ZoTVQnWzwtIj0S9HDolEELG0e/s0KJJ7aAKEQtaUzBECF2zBPVEIwLCtp4dKFeTDdf1zuAoDiv7/xqrdsATxhgB+VaAPBkhYNjXPG+jAScsbkpzzVWD+g=;20:wVtYz+y0yz4ywaQA3SlUt2pBlxy/3TskNry99EYBCQ84q6+S6PiWDR98sf1FuENP4wacDAlYSa8l6HBjk8CQ2pYrHGOMeIFMgDCTDUNSJD6dHViRvhoCzjXO4/73s5mphVzZlUxSQ0h9j6CUVg7B5V7YsFQHodan0uyCAugwP8xtULXmiBpneqUGAev6kEtJqjrkfrN3mHXnjA+d88E/P4ULyrJMm/YgairP10s+gRrAuJVfHmvhTxQzpjgeCmezj0rUKNjYBne3C2HmNCgI81RLtPPo+dP5N8cr1tNpARAOuFZlBMs8agyDbpNLJ//2BBxZYqWRPntkpmWmdONNMS/7rsX277HBUrbQUbKU8sjb6ebU1WtO63g7DQpoWbKWrUqPtyhqPsqZBEhJKxRCRxQeeADojdG3R4VxlVPn7D7G/OzHDWMRTkcC/8EvkF4hGOX/aOnW+NwMer5wsUEQ5fpQPPUBnZiwjO7KDrV87D08Xbb90VYPrUHO1dOEj+he X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592)(189271028609987)(145744241990776); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13015025)(13017025)(13023025)(13018025)(13024025)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:CY1PR0201MB0921;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB0921; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB0921;4:3Q/H/32lLd0LxjHEHN1Llew0DQN5nq+h6PK+j4ETtDOS6cEggKgMuA/EhxUDDBxbIVy1WtN9aYQvvYmAM3CYLenOK0ybysHABnztcXmSv05IY6UBfOPD3zb/83CmxqCJOQVQWqmu2tS5ieMhWNeYHkcCeJtZK0bIUBt8PJtLwYg2lFoilNlioh6pqwTD/B1XoGoy7YAM4qjDp9FVGFpvZYYVDS38HYBRsLejqwVFdTb3EbuSVF04etuzKispntGCn8GaPz4D7sXIGM1E6CdAnMkQqJ9uixC+BkOvQuXwVq2uUp1GVhBrGJGyAt6+H7cQDZbAWo28ctMIYWaZ0xpLpoUBpBU3e8tnq3lsVvhIJmp2Ja9m6VB0NtZmYR0OS1kjdPOl17lW6b6m3aAkUCZIDW8I1M1OWA09nJBH7qgqLNiTgJLh0uGS5IZx0YUKmTT/hLes6gkVg7icEyGl+qwIDkSC94aeiMBDNVUpS74nzVKj52YWlFBfIG0yOfwZulTQicbQB7FbcBi4GR1YeYF7YrlbN1q0mKWBNEwCj0m8fiacKx0s9A7hwqEH9IftEefKLYxbE0/6cXdCW1sN1jh06YjQYyIozg5gxK+B0Drsils= X-Forefront-PRVS: 00603B7EEF X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR0201MB0921;23:zweYq7kwGepJWu2SSUSppvLxm4HSIsOKvIT?= =?Windows-1252?Q?YME0rwnyzWMA40lz4PpHjqqNEtgMu0rwJ4zdBRtbU8BDEQbMrY8M9BWD?= =?Windows-1252?Q?u9Sgfci3lMkBBA9QzwrUSydwei47x5JySZijJqIYzdkYmAmymoMDynjX?= =?Windows-1252?Q?Rij1c5zBiJcHONhO3Om/aVdlb6H0bRIlcAwePSQmQhH6sg6jh+5ZsKVO?= =?Windows-1252?Q?+6g8vRm/FaF3Z4GgJfFo9UUnkUNVmFNwA6JzI09RdMNurdfjcYHJQBUx?= =?Windows-1252?Q?XpKKRlUNPtvfFHYdoVzvHenlGfC9TLRGNDHelaIK5/2FV3IST5eNdcNr?= =?Windows-1252?Q?t+oaDpb21DAR3qH5cJ9Wn7ssB3Jm2xjrZLG7vCNzYMa4X3hPNHOD7van?= =?Windows-1252?Q?cRFtle+aOfLBzmYv/DdjlopiN21c3mY2gReRvA4OEuAkvPNs+Ka12tbf?= =?Windows-1252?Q?ZEkOWUbfyAvUjXOTb4jpL2DNtQGox7oku5jPR9EJnkegKMYkR67YTb8M?= =?Windows-1252?Q?LRq9dNq1wmI6YImOKbhy4CHKbSScA9A71N37JqrPkRGJX/tvY8S5UhvA?= =?Windows-1252?Q?Tm09jNwGP9IJzQ8xxpFmZpj24cWEbakxOxALAMZND8gZkjjo12LcDoG6?= =?Windows-1252?Q?RAAoIIFgqloC29HttcGNZQdzrcyiQYsImCfd6cLqpgzsF2xezAG41Rw8?= =?Windows-1252?Q?uhagcDxmtB1tH+a/XJn3trGS15afXhbOOBKIzEaNYHWZgw4uPx/laJJj?= =?Windows-1252?Q?zn+l26JmjVEZp1hZkO4iyYhYz6+SelkXswK2XEWdM7teIWtD+MWFDuMQ?= =?Windows-1252?Q?vF0TtJjegqsbiPomuCsODJGROVNKVUgpOWuoRmRa4assZGUma/0kz632?= =?Windows-1252?Q?MTV/yRBkD3h+2QZGQm9hi404wboMLw1dLPAa448Qv8QKjwiZ2Ed3grSd?= =?Windows-1252?Q?hFo3nINH3RhoZd2+b1XcaeBY4ydL6QTT8HyXd8rfyTo1uhdaQrlEc6zO?= =?Windows-1252?Q?vNz0vGPnNnFVmu212/XDGUZY1zAKgtEjL7cXpzsHQLk8Dm50M3X9vxji?= =?Windows-1252?Q?GBustLvs8Kt7aZujuLnjAcjspH2rQRLVKxpWNEi6zyJVFPMyWOdAqjE5?= =?Windows-1252?Q?6fM5/fKBD4JHs/msqxENnrS7WlJmgZOFUeJqli7YY2+W0nuT6clBSpvZ?= =?Windows-1252?Q?oZVlHHoBu2YKvAWYfdMbURelltUhouBN5NX6MF4tczpJB9Q1rC7G+qCI?= =?Windows-1252?Q?o1ESRTSsU6hhgIDnZVTPEsgyxP68LDCmEnozZ7fw+Tz7QNcco4gTE+tn?= =?Windows-1252?Q?PlPdIeL6IUEpfyjZcV/m2M3Mr9KgxzWF/RfmHHrEJmW2aEfd7yjCyYUe?= =?Windows-1252?Q?dG+yejo5SomRKgBRlREil/XID1YfE8VKzw1kA++nBDppIez1WdAK0OJt?= =?Windows-1252?Q?8SFVJiUE8pv+TS1CsN5tq?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB0921;6:Cdy4tL/+i4psTPHBoktQXRdvMZ/Qe/ytsm4VaKrVIFVhBYfvsrxbBLc6sMkGa6XOFYIvClZ11TN2F5PiL01DK9MJdjDGcKCCBRSMQolDziBRgFximpuh0Yyz48E8D9ezEMLKrFSsy6Q8kI2OmVtMxGWM/WbJOAO2lZheXt2YH6YN5BDfDK2eiPIA3tjzyfqmLbOa9Oruc+XcFn50CxvfI/AKExi9UpXvQubMtRSYjCHjjg3NGvyw2hPXoWwVgMQvpKcr2EIHU/ja2cFDRxJgGrKoNCwOfAn/bdp/tVeW0y2RJnQLPGZcQL7v2isrtFLTVuq8erbrPOXUaRQhh2NvEg==;5:Xhrfc16aozcAxvgW1S55gJ8Ezbi1XfrdTAqdtLzAuYlGnBi/rn4ugI9Gcd3dFStgIbUOZufL7M3+H96Zi0sCd4lZ+ZASt1dIZDg6PjV9g325jI6hHugALY1GsCmfXXagqqvSM3GGpZtF7t/EnzQdRQ==;24:Kx3dKAT1Wf9eGNEsh+rBxMazQ1mD6a9MEU7U0AH0J3n/eLjq6GrFqZ4lEtA26DpwfSEDi83xqfHLzLMhAsySVM4v3ru0zeJVXl5f2FDWV74=;7:7vcLV7dzbOuBm6GaZ1dQFhoiy4I4GaPitchicCkkwjJd72KX7bx9zyA0gcL5SERngBhwu8Xd87KcDmVxym/xyC6gaEkrAmW22iOE3CBsphle07Eb/64wnFpE+k0CmiRcVLk2EtBjkbPkiZQlpOqVxSjW7G0tdSlWjb/z8L052aJXzVYF8fi6GOrZ5Gx89c2WOZ4fXuh2LO2U6FrmXqOxuv36JVog0mdGSEgbHwarV+grrQqBLymM5mfAb9CeK3f+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2016 06:36:18.7902 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB0921 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8.9.2016 21:42, Zach Brown wrote: > The sdhci controller on xilinx zynq devices will not function unless > the CD bit is provided. http://www.xilinx.com/support/answers/61064.html > In cases where it is impossible to provide the CD bit in hardware, > setting the controller to test mode and then setting inserted to true > will get the controller to function without the CD bit. > > The device property "xlnx-fails-without-test-cd" will let the arasan > driver know the controller does not have the CD line wired and that the > controller does not function without it. > > Signed-off-by: Zach Brown > --- > v2: > * improved commit messages > * removed fake-cd device property > * removed fake-cd quirk > * use broken-cd device property > * documented new usage of broken-cd > v3: > * removed new usage of broken-cd > * created fails-without-test-cd device property > * created arasan controller specific quirk > v4: > * changed fails-without-test-cd to xlnx-fails-without-test-cd > * removed extra blank line > v5: > * Fixed style mistake > * Changed (1 << 0 ) to BIT(0) > v6: > * Fixed style mistakes > * Condensed unnecessarily long variable names > * Removed line wraps that were no longer necessary. > * Rebased changes off Ulf's mmc tree's next branch. > > > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > df --gt /Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > index 3404afa..e71f043 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > @@ -21,6 +21,10 @@ Required Properties: > - interrupts: Interrupt specifier > - interrupt-parent: Phandle for the interrupt controller that services > interrupts for this device. > +Optional Properties: > +- xlnx-fails-without-test-cd: when present, the controller doesn't work when xlnx, here. Thanks, Michal