From: Kishon Vijay Abraham I <kishon@ti.com>
To: <balbi@ti.com>
Cc: Andy Gross <agross@codeaurora.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Jack Pham <jackp@codeaurora.org>,
Kumar Gala <galak@codeaurora.org>,
<linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>
Subject: Re: [Patch v9 3/3] phy: Add Qualcomm DWC3 HS/SS PHY driver
Date: Mon, 15 Sep 2014 12:07:12 +0530 [thread overview]
Message-ID: <54168918.1080408@ti.com> (raw)
In-Reply-To: <20140914022452.GA16652@saruman.home>
Hi,
On Sunday 14 September 2014 07:54 AM, Felipe Balbi wrote:
> Hi,
>
> On Sat, Sep 13, 2014 at 12:16:01PM +0530, Kishon Vijay Abraham I wrote:
>> On Saturday 13 September 2014 12:58 AM, Andy Gross wrote:
>>> This patch adds a new driver for the Qualcomm USB 3.0 PHY that exists on some
>>> Qualcomm platforms. This driver uses the generic PHY framework and will
>>> interact with the DWC3 controller.
>>
>> Do you have dt documentation for this driver?
>
> see patch 1
hmm.. missed that.
>
>>> +static inline void qcom_dwc3_phy_write_readback(
>>> + struct qcom_dwc3_usb_phy *phy_dwc3, u32 offset,
>>> + const u32 mask, u32 val)
>>> +{
>>> + u32 write_val, tmp = readl(phy_dwc3->base + offset);
>>> +
>>> + tmp &= ~mask; /* retain other bits */
>>> + write_val = tmp | val;
>>> +
>>> + writel(write_val, phy_dwc3->base + offset);
>>> +
>>> + /* Read back to see if val was written */
>>
>> Does it fail sometime? I'm not sure if this should be present in the
>> driver since this looks more of a debug code.
>
> this was mentioned before. Silicon bug.
okay.
>
>>> + writel_relaxed(data | SSUSB_CTRL_SS_PHY_RESET,
>>> + phy_dwc3->base + SSUSB_PHY_CTRL_REG);
>>> + usleep_range(2000, 2200);
>>
>> use msleep here..
>
> why ? usleep_range() gives the scheduler oportunity to group timers.
Was of the opinion that for larger delays msleep should be used. But looks like
it is only for 10+ ms (Documentation/timers/timers-howto.txt).
Thanks
Kishon
next prev parent reply other threads:[~2014-09-15 6:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 19:28 [Patch v9 0/3] DWC3 USB support for Qualcomm platform Andy Gross
2014-09-12 19:28 ` [Patch v9 1/3] usb: dwc3: qcom: Add device tree binding Andy Gross
2014-09-16 18:15 ` Jack Pham
2014-09-16 18:29 ` Felipe Balbi
2014-09-12 19:28 ` [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver Andy Gross
[not found] ` <CAMf-jSm2fPPstFD2h4-gG=MCDty34f-O0ooizDEKyQUd3+CxGQ@mail.gmail.com>
2014-09-12 20:20 ` Felipe Balbi
2014-09-12 20:25 ` Pramod Gurav
2014-09-12 20:29 ` Felipe Balbi
2014-09-12 20:33 ` Pramod Gurav
2014-09-12 19:28 ` [Patch v9 3/3] phy: Add Qualcomm DWC3 HS/SS PHY driver Andy Gross
2014-09-13 6:46 ` Kishon Vijay Abraham I
2014-09-14 2:24 ` Felipe Balbi
2014-09-15 6:37 ` Kishon Vijay Abraham I [this message]
2014-09-16 18:27 ` Jack Pham
2014-09-16 20:39 ` Andy Gross
2015-01-22 18:59 ` Jack Pham
2015-01-22 21:44 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54168918.1080408@ti.com \
--to=kishon@ti.com \
--cc=agross@codeaurora.org \
--cc=balbi@ti.com \
--cc=bjorn.andersson@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=jackp@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).