From: Rob Jones <rob.jones@codethink.co.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-kernel@codethink.co.uk
Subject: Re: [PATCH 0/2] fs: proc: use seq_open_private()
Date: Mon, 15 Sep 2014 08:21:45 +0100 [thread overview]
Message-ID: <54169389.6060608@codethink.co.uk> (raw)
In-Reply-To: <20140912145019.9e1665011c2d2e9bcb55f0c1@linux-foundation.org>
On 12/09/14 22:50, Andrew Morton wrote:
> On Fri, 12 Sep 2014 15:09:36 +0100 Rob Jones <rob.jones@codethink.co.uk> wrote:
>
>> fs: proc: use __seq_open_private()
>> fs: proc: use __seq_open_private()
>
> See the problem? We have two different patches, both named the same.
Always another gotcha! :-)
Seriously, does it say anywhere that patch names have to be unique? It
makes perfect sense when it's pointed out but it never occurred to me.
I'll make sure I don't do it again.
>
> I renamed them to
>
> fs/proc/task_nommu.c: use __seq_open_private()
> fs/proc/task_mmu.c: use __seq_open_private()
Thank you, much appreciated. I would have been happy to re-submit.
>
> I really don't understand this practice of replacing "/" with ": " in
> patch titles. Why not just use the "/"?
I'll do this in future too.
Sigh. So much to learn.
--
Rob Jones
Codethink Ltd
mailto:rob.jones@codethink.co.uk
tel:+44 161 236 5575
next prev parent reply other threads:[~2014-09-15 7:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 14:09 [PATCH 0/2] fs: proc: use seq_open_private() Rob Jones
2014-09-12 14:09 ` [PATCH 1/2] fs: proc: use __seq_open_private() Rob Jones
2014-09-12 21:54 ` Andrew Morton
2014-09-15 13:42 ` Rob Jones
2014-09-29 16:02 ` Rob Jones
2014-09-12 14:09 ` [PATCH 2/2] " Rob Jones
2014-09-12 21:50 ` [PATCH 0/2] fs: proc: use seq_open_private() Andrew Morton
2014-09-15 7:21 ` Rob Jones [this message]
2014-09-15 7:27 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54169389.6060608@codethink.co.uk \
--to=rob.jones@codethink.co.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).