From: Jaehoon Chung <jh80.chung@samsung.com>
To: Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>,
Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"tgih.jun@samsung.com" <tgih.jun@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Chris Ball <chris@printf.net>
Subject: Re: [PATCH] mmc: Add delay between CMD6 and CMD13 for Sandisk eMMC cards
Date: Mon, 15 Sep 2014 19:44:28 +0900 [thread overview]
Message-ID: <5416C30C.6010400@samsung.com> (raw)
In-Reply-To: <CAL8zT=iezoevh_12GAZyDOdRy1dAS876RZDUJGVTZyY4zYZbaQ@mail.gmail.com>
On 09/15/2014 07:08 PM, Jean-Michel Hautbois wrote:
> Hi Jaehoon,
>
>> On 09/09/2014 09:26 PM, Jean-Michel Hautbois wrote:
>>> Tested on a i.MX6 board, with Sandisk SDIN5D1-2G.
>>> Without this patch, I/O errors occur.
>>> This eMMC seems to have a different Manufacturer ID as it reads 0x45
>>> and not 0x2 as specified in datasheet.
>>
>> I think this patch don't merge into mainline.
>> This is not solution for problem.
>> you mentioned the below comment, this is workaround.
>
> Yes
>
>>>
>>> Signed-off-by: Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>
>>> ---
>>> drivers/mmc/core/mmc_ops.c | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>>
>>> diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
>>> index f51b5ba..91babaa 100644
>>> --- a/drivers/mmc/core/mmc_ops.c
>>> +++ b/drivers/mmc/core/mmc_ops.c
>>> @@ -458,6 +458,15 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
>>> if (!use_busy_signal)
>>> return 0;
>>>
>>> + /* WORKAROUND: for Sandisk eMMC cards, it might need certain delay
>>> + * before sending CMD13 after CMD6
>>> + * On SDIN5D1-2G MANFID is 0x45 and not 0x2 as specified in datasheet
>>> + */
>>> + if (card->cid.manfid == CID_MANFID_SANDISK ||
>>> + card->cid.manfid == 0x45) {
>>> + msleep(1);
>>> + }
>>
>> If it's a general problem of Sandisk SDIN5D1-2G,
>> I think you need to verify this problem. And can you use the MMC_FIXUP() and QUIRK?
>
> Well, this is difficult to verify, I know that on all my SDIN5D1-2G I
> have this MANFID different from what is defined by CID_MANFID_SANDISK.
> How should I use MMC_FIXUP ? Like this ?
I think you need to explain why delay is need.
i didn't have same card, but it might be your host controller or other problem.
You can define the 0x45 with other naming.
ex) CID_MANFID_SANDISK_2 0x45 ? Just example.:)
And Your first patch is applied for every Sandisk card, isn't?
Best Regards,
Jaehoon Chung
> MMC_FIXUP("SEM02G", 0x45, CID_OEMID_ANY, add_quirk, MMC_QUIRK_INAND_CMD13) ?
>
> If so, can I use :
> if (card->quirks & MMC_QUIRK_INAND_CMD38)
> msleep(1);
>
> In drivers/mmc/core/mmc_ops.c ?
> Is this the good way ?
>
> Thanks,
> JM
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2014-09-15 10:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 12:26 [PATCH] mmc: Add delay between CMD6 and CMD13 for Sandisk eMMC cards Jean-Michel Hautbois
2014-09-11 2:38 ` Jaehoon Chung
2014-09-15 10:08 ` Jean-Michel Hautbois
2014-09-15 10:44 ` Jaehoon Chung [this message]
2014-09-15 10:53 ` Jean-Michel Hautbois
2014-09-15 11:29 ` Jean-Michel Hautbois
2014-09-16 0:53 ` hisanao.kinkawa
2014-09-21 17:48 ` Pavel Machek
2014-09-22 2:59 ` Jaehoon Chung
2014-09-22 7:23 ` Jean-Michel Hautbois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5416C30C.6010400@samsung.com \
--to=jh80.chung@samsung.com \
--cc=chris@printf.net \
--cc=jean-michel.hautbois@vodalys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).