From: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: <stefan@agner.ch>, <linux@arm.linux.org.uk>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] ARM: dts: vf610-colibri: Add PWM support
Date: Fri, 19 Sep 2014 15:49:09 +0530 [thread overview]
Message-ID: <541C031D.2010208@toradex.com> (raw)
In-Reply-To: <20140918141248.GL4796@dragon>
On Thursday 18 September 2014 07:42 PM, Shawn Guo wrote:
> On Wed, Sep 17, 2014 at 01:46:29PM +0530, Bhuvanchandra DV wrote:
>> The Colibri standard defines four pins as PWM outputs, two of them (PWM
>> A and C) are routed to FTM instance 0 and the other two (PWM B and D)
>> are routed to FTM instance 1. Hence enable both FTM instances for the
>> Colibri module and mux the four pins accordingly.
>>
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>> ---
>> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 ++++++++
>> arch/arm/boot/dts/vf610-colibri.dtsi | 25 +++++++++++++++++++++++++
>> 2 files changed, 33 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> index 7fb3066..ba98039 100644
>> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> @@ -44,3 +44,11 @@
>> &uart2 {
>> status = "okay";
>> };
>> +
>> +&pwm0 {
>> + status = "okay";
>> +};
>> +
>> +&pwm1 {
>> + status = "okay";
>> +};
> Please sort the node alphabetically, so that we can locate them more
> easily.
Ok, will sort the nodes alphabetically
>> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
>> index 0cd8343..9bd1415 100644
>> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
>> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
>> @@ -69,6 +69,16 @@
>> status = "okay";
>> };
>>
>> +&pwm0 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_pwm0>;
>> +};
>> +
>> +&pwm1 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_pwm1>;
>> +};
>> +
> Ditto
Ok
>> &iomuxc {
>> vf610-colibri {
>> pinctrl_esdhc1: esdhc1grp {
>> @@ -119,5 +129,20 @@
>> VF610_PAD_PTD3__UART2_CTS 0x21a1
>> >;
>> };
>> +
>> + pinctrl_pwm0: pwm0grp {
> We also maintain the alphabetic order of pinctrl_* entries under iomuxc
> node.
>
> Shawn
Ok
>> + fsl,pins = <
>> + VF610_PAD_PTB0__FTM0_CH0 0x1182
>> + VF610_PAD_PTB1__FTM0_CH1 0x1182
>> + >;
>> + };
>> +
>> + pinctrl_pwm1: pwm1grp {
>> + fsl,pins = <
>> + VF610_PAD_PTB8__FTM1_CH0 0x1182
>> + VF610_PAD_PTB9__FTM1_CH1 0x1182
>> + >;
>> + };
>> +
>> };
>> };
>> --
>> 1.7.9.5
>>
next prev parent reply other threads:[~2014-09-19 10:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 8:16 [PATCH 0/3] Add PWM and backlight support for Colibri VF61 modules Bhuvanchandra DV
2014-09-17 8:16 ` [PATCH 1/3] ARM: dts: vf610: Add PWM second instance Bhuvanchandra DV
2014-09-17 8:16 ` [PATCH 2/3] ARM: dts: vf610-colibri: Add PWM support Bhuvanchandra DV
2014-09-18 14:12 ` Shawn Guo
2014-09-19 10:19 ` Bhuvanchandra DV [this message]
2014-09-17 8:16 ` [PATCH 3/3] ARM: dts: vf610-colibri: Add backlight support Bhuvanchandra DV
2014-09-18 14:17 ` Shawn Guo
2014-09-19 10:27 ` Bhuvanchandra DV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541C031D.2010208@toradex.com \
--to=bhuvanchandra.dv@toradex.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=shawn.guo@freescale.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).