linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.cz,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	"Chew, Kean Ho" <kean.ho.chew@intel.com>
Subject: Re: [PATCHv2] serial: 8250: Add Quark X1000 to 8250 PCI driver
Date: Fri, 19 Sep 2014 12:35:03 +0100	[thread overview]
Message-ID: <541C14E7.8020208@nexus-software.ie> (raw)
In-Reply-To: <20140919105833.GB31784@xps8300>

On 19/09/14 11:58, Heikki Krogerus wrote:
> On Fri, Sep 19, 2014 at 08:43:49AM +0100, Bryan O'Donoghue wrote:
>> Adds PCI identifier for the X1000
>> Adds clocking and register size and register shift
>>
>> Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
>> ---
>>   drivers/tty/serial/8250/8250_pci.c | 33 +++++++++++++++++++++++++++++++++
>>   1 file changed, 33 insertions(+)
>
> The UART on Quark SoC has an integrated DMA engine and Kean Ho (CC'd)
> is working with support for it. The plan is to add completely separate
> probe driver for the Quark UART. Dealing with the integrated DMA
> engine is too much for a quirk in 8250_pci.c.
>
> So we can take this now and when Kean Ho is ready he needs to
> basically revert it, or you could already introduce the new probe
> driver, 8250_quark.c, and Kean Ho can then add the DMA engine handling
> later to it.
>
> IMO we should add the 8250_quark.c already now.

Sounds great - is the 8250_quark.c code ready ?

If so then fantastic I agree with you.

If not then, lets do as you suggest Heikki and apply the simple patch 
above in the interim.


Best,
BOD



  parent reply	other threads:[~2014-09-19 11:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19  7:43 [PATCHv2] serial: 8250: Add Quark X1000 to 8250 PCI driver Bryan O'Donoghue
2014-09-19 10:58 ` Heikki Krogerus
2014-09-19 11:34   ` Andy Shevchenko
2014-09-19 11:35   ` Bryan O'Donoghue [this message]
2014-09-19 12:06     ` Chew, Kean Ho
2014-09-19 13:02       ` Bryan O'Donoghue
2014-09-19 13:10         ` Chew, Kean Ho
2014-09-19 13:25           ` Bryan O'Donoghue
2014-09-19 14:31             ` Chew, Kean Ho
2014-09-19 15:38               ` Bryan O'Donoghue
2014-09-22  7:12 ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541C14E7.8020208@nexus-software.ie \
    --to=pure.logic@nexus-software.ie \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jslaby@suse.cz \
    --cc=kean.ho.chew@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).