From: Juri Lelli <juri.lelli@arm.com>
To: Daniel Wagner <daniel.wagner@bmw-carit.de>,
"peterz@infradead.org" <peterz@infradead.org>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
"juri.lelli@gmail.com" <juri.lelli@gmail.com>,
"raistlin@linux.it" <raistlin@linux.it>,
"michael@amarulasolutions.com" <michael@amarulasolutions.com>,
"fchecconi@gmail.com" <fchecconi@gmail.com>,
"vincent@legout.info" <vincent@legout.info>,
"luca.abeni@unitn.it" <luca.abeni@unitn.it>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] sched/deadline: clear dl_entity params when setscheduling to different class
Date: Fri, 19 Sep 2014 13:43:24 +0100 [thread overview]
Message-ID: <541C24EC.1080200@arm.com> (raw)
In-Reply-To: <541C171E.6080900@bmw-carit.de>
Hi Daniel,
On 19/09/14 12:44, Daniel Wagner wrote:
> Hi,
>
> On 09/19/2014 11:22 AM, Juri Lelli wrote:
>> When a task is using SCHED_DEADLINE and the user setschedules it to a different
>> class its sched_dl_entity static parameters are not cleaned up. This causes a
>> bug if the user sets it back to SCHED_DEADLINE with the same parameters again.
>> The problem resides in the check we perform at the very beginning of
>> dl_overflow():
>>
>> if (new_bw == p->dl.dl_bw)
>> return 0;
>>
>> This condition is met in the case depicted above, so the function returns and
>> dl_b->total_bw is not updated (the p->dl.dl_bw is not added to it). After this,
>> admission control is broken.
>>
>> This patch fixes the thing, properly clearing static parameters for a task
>> that ceases to use SCHED_DEADLINE.
>>
>> Reported-by: Daniele Alessandrelli <daniele.alessandrelli@gmail.com>
>> Reported-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> Tested-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> Fixes my problem.
>
Great! Thanks for testing it.
Best,
- Juri
next prev parent reply other threads:[~2014-09-19 12:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 9:22 [PATCH 0/3] SCHED_DEADLINE fix AC and SMP scheduling Juri Lelli
2014-09-19 9:22 ` [PATCH 1/3] sched/deadline: clear dl_entity params when setscheduling to different class Juri Lelli
2014-09-19 11:44 ` Daniel Wagner
2014-09-19 12:43 ` Juri Lelli [this message]
2014-09-22 18:50 ` Vincent Legout
2014-09-24 14:54 ` [tip:sched/core] sched/deadline: Clear " tip-bot for Juri Lelli
2014-10-08 12:32 ` [PATCH 1/3] sched/deadline: clear " Wanpeng Li
2014-10-21 12:15 ` Wanpeng Li
2014-10-21 13:15 ` Juri Lelli
2014-09-19 9:22 ` [PATCH 2/3] sched/deadline: fix bandwidth check/update when migrating tasks between exclusive cpusets Juri Lelli
2014-09-19 11:47 ` Daniel Wagner
2014-09-19 12:46 ` Juri Lelli
2014-09-19 21:25 ` Peter Zijlstra
2014-09-23 8:12 ` Juri Lelli
2014-10-07 8:59 ` Juri Lelli
2014-10-07 12:31 ` Peter Zijlstra
2014-10-07 13:12 ` Juri Lelli
2014-10-28 11:07 ` [tip:sched/core] sched/deadline: Ensure that updates to exclusive cpusets don't break AC tip-bot for Juri Lelli
2014-09-22 19:24 ` [PATCH 2/3] sched/deadline: fix bandwidth check/update when migrating tasks between exclusive cpusets Vincent Legout
2014-09-23 8:09 ` Juri Lelli
2014-09-23 13:08 ` Daniel Wagner
2014-10-28 11:07 ` [tip:sched/core] sched/deadline: Fix bandwidth check/ update " tip-bot for Juri Lelli
2014-09-19 9:22 ` [PATCH 3/3] sched/deadline: fix inter- exclusive cpusets migrations Juri Lelli
2014-09-24 14:55 ` [tip:sched/core] sched/deadline: Fix " tip-bot for Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541C24EC.1080200@arm.com \
--to=juri.lelli@arm.com \
--cc=daniel.wagner@bmw-carit.de \
--cc=fchecconi@gmail.com \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@unitn.it \
--cc=michael@amarulasolutions.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=raistlin@linux.it \
--cc=vincent@legout.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).