From: Guenter Roeck <linux@roeck-us.net>
To: David Miller <davem@davemloft.net>, anish@chelsio.com
Cc: rdunlap@infradead.org, sfr@canb.auug.org.au,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
JBottomley@parallels.com, mchan@broadcom.com
Subject: Re: linux-next: Tree for Sep 19
Date: Fri, 19 Sep 2014 19:40:45 -0700 [thread overview]
Message-ID: <541CE92D.70301@roeck-us.net> (raw)
In-Reply-To: <20140919.220856.2166907140359359148.davem@davemloft.net>
On 09/19/2014 07:08 PM, David Miller wrote:
> From: Anish Bhatt <anish@chelsio.com>
> Date: Sat, 20 Sep 2014 01:43:05 +0000
>
>> Original config causing issues can be seen here :
>> https://lkml.org/lkml/2014/9/9/500
>>
>> As CNIC depends on IPV6, CNIC can be only compiled as a module when IPV6 is
>> compiled as a module. This was the patch I originally commited. Previous
>> behaviour was to disable all ipv6 code in such a case. However, having bnx2fc/i
>> as built-in overrides CNIC's tristate from m to built-in (as they select CNIC),
>> causing build issues. As far as I know, there is no way to control the state
>> that select sets.
>
> Really, nothing that has dependencies should be "select"'d, ever.
>
> What people hack up is that they try to do this, and "make it work"
> by "select"'ing all of the selected object's dependencies. And
> then you have to do this recursively for dependencies which have
> dependencies.
>
> This is really incredibly stupid.
>
> And once something in that chain gains a new dependency, all of
> these "select" instances break.
>
> I really want all of these netlink users to "depend" on "NET"
> rather than "select" it, and so on and so forth down to the
> users of these netlink using subsystems.
>
Sure, that makes sense on some level, but you would have to make sure
that any changes made are clean and don't break existing configurations,
and/or you would have to make sure that all affected configurations are
updated as needed. A single-line change in a configuration file, to hell
with the consequences, just doesn't cut it.
We already know that 11 out of 55 mips configurations are broken in
linux-next. I don't even want to know what else is broken. That is
a pretty high price to pay to achieve purity.
Guenter
next prev parent reply other threads:[~2014-09-20 2:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 6:58 linux-next: Tree for Sep 19 Stephen Rothwell
2014-09-19 19:04 ` Guenter Roeck
2014-09-19 19:15 ` Guenter Roeck
2014-09-20 19:36 ` Helge Deller
2014-09-20 21:01 ` Guenter Roeck
2014-09-21 19:43 ` Helge Deller
2014-09-19 19:42 ` Guenter Roeck
2014-09-19 20:06 ` Guenter Roeck
2014-09-22 14:40 ` Christoph Hellwig
2014-09-19 20:24 ` Guenter Roeck
2014-09-22 14:35 ` Christoph Hellwig
2014-09-19 21:14 ` Guenter Roeck
2014-09-19 21:42 ` Anish Bhatt
2014-09-20 0:18 ` Guenter Roeck
2014-09-19 22:21 ` Randy Dunlap
2014-09-19 22:28 ` Anish Bhatt
2014-09-19 22:35 ` Randy Dunlap
2014-09-20 0:15 ` Guenter Roeck
2014-09-20 1:09 ` Randy Dunlap
2014-09-20 1:43 ` Anish Bhatt
2014-09-20 2:08 ` David Miller
2014-09-20 2:40 ` Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-09-19 6:37 Stephen Rothwell
2022-09-19 9:47 Stephen Rothwell
2019-09-19 16:06 Mark Brown
2018-09-19 6:16 Stephen Rothwell
2017-09-19 4:15 Stephen Rothwell
2016-09-19 7:02 Stephen Rothwell
2013-09-19 3:59 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541CE92D.70301@roeck-us.net \
--to=linux@roeck-us.net \
--cc=JBottomley@parallels.com \
--cc=anish@chelsio.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).