From: Mark yao <mark.yao@rock-chips.com>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: heiko@sntech.de,
"Boris BREZILLON" <boris.brezillon@free-electrons.com>,
"David Airlie" <airlied@gmail.com>,
"Rob Clark" <robdclark@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Grant Likely" <grant.likely@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"John Stultz" <john.stultz@linaro.org>,
"Rom Lemarchand" <romlem@google.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Linux API" <linux-api@vger.kernel.org>,
linux-rockchip@lists.infradead.org, dianders@chromium.org,
"Stéphane Marchesin" <marcheu@chromium.org>,
dbehr@chromium.org, "Olof Johansson" <olof@lixom.net>,
"Daniel Kurtz" <djkurtz@chromium.org>,
xjq@rock-chips.com, kfx@rock-chips.com, cym@rock-chips.com,
cf@rock-chips.com, zyw@rock-chips.com, xxm@rock-chips.com,
huangtao@rock-chips.com, kever.yang@rock-chips.com,
yxj@rock-chips.com, wxt@rock-chips.com, xw@rock-chips.com
Subject: Re: [PATCH v3 1/5] drm/rockchip: Add basic drm driver
Date: Mon, 22 Sep 2014 09:27:33 +0800 [thread overview]
Message-ID: <541F7B05.2000605@rock-chips.com> (raw)
In-Reply-To: <CANq1E4Ti0yOQ+jCiXy7=NtFQ9cbWLOSLf6q-HWVdDFtMB1n29Q@mail.gmail.com>
On 2014年09月19日 21:04, David Herrmann wrote:
> Hi
>
> On Fri, Sep 19, 2014 at 7:47 AM, Mark yao <mark.yao@rock-chips.com> wrote:
> [snip]
>> +static int rockchip_drm_bind(struct device *dev)
>> +{
>> + return drm_platform_init(&rockchip_drm_driver, to_platform_device(dev));
> Please avoid drm_platform_*() usage. We're about to drop all the
> drm_bus midlayers. See the tegra driver how to do it, but basically
> just this:
OK, I will do it.
> struct drm_device *ddev;
>
> ddev = drm_dev_alloc(&rockchip_drm_driver, &to_platform_device(dev)->dev);
> if (!ddev)
> return -ENOMEM;
>
> r = drm_dev_set_unique(ddev, dev_name(&ddev->dev));
> if (r < 0) {
> drm_dev_unref(ddev);
> return r;
> }
>
> r = drm_dev_register(ddev);
> if (r < 0) {
> drm_dev_unref(ddev);
> return r;
> }
>
>> +}
>> +
>> +static void rockchip_drm_unbind(struct device *dev)
>> +{
>> + drm_put_dev(dev_get_drvdata(dev));
> Please use:
>
> struct drm_device *ddev = dev_get_drvdata(dev);
>
> drm_dev_unregister(ddev);
> drm_dev_unref(ddev);
>
>
> Thanks
> David
>
>
>
next prev parent reply other threads:[~2014-09-22 1:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 5:47 [PATCH v3 0/5] Add drm driver for Rockchip Socs Mark yao
2014-09-19 5:47 ` [PATCH v3 1/5] drm/rockchip: Add basic drm driver Mark yao
2014-09-19 13:04 ` David Herrmann
2014-09-22 1:27 ` Mark yao [this message]
2014-09-20 0:03 ` Rob Clark
2014-09-22 1:32 ` Mark yao
2014-09-23 7:48 ` Daniel Vetter
2014-09-23 8:00 ` Mark yao
2014-09-19 5:52 ` [PATCH v3 2/5] dt-bindings: video: Add for rockchip display subsytem Mark yao
2014-09-19 5:53 ` [PATCH v3 3/5] dt-bindings: video: Add documentation for rockchip vop Mark yao
2014-09-19 5:54 ` [PATCH v3 4/5] dt-bindings: video: Add documentation for rockchip edp Mark yao
2014-09-19 5:56 ` [PATCH v3 5/5] drm/rockchip: Add support for Rockchip Soc EDP Mark yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541F7B05.2000605@rock-chips.com \
--to=mark.yao@rock-chips.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=cf@rock-chips.com \
--cc=cym@rock-chips.com \
--cc=dbehr@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dh.herrmann@gmail.com \
--cc=dianders@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=john.stultz@linaro.org \
--cc=kever.yang@rock-chips.com \
--cc=kfx@rock-chips.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=marcheu@chromium.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=romlem@google.com \
--cc=wxt@rock-chips.com \
--cc=xjq@rock-chips.com \
--cc=xw@rock-chips.com \
--cc=xxm@rock-chips.com \
--cc=yxj@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).