* [PATCH] extcon: sm5502: Drop useless include
@ 2014-09-16 21:16 Jean Delvare
2014-09-22 7:01 ` Chanwoo Choi
0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2014-09-16 21:16 UTC (permalink / raw)
To: Chanwoo Choi, MyungJoo Ham; +Cc: linux-kernel
Don't include <linux/input.h> when the driver does not use anything
from this header file.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
---
drivers/extcon/extcon-sm5502.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/extcon/extcon-sm5502.c
+++ b/drivers/extcon/extcon-sm5502.c
@@ -17,7 +17,6 @@
#include <linux/err.h>
#include <linux/i2c.h>
-#include <linux/input.h>
#include <linux/interrupt.h>
#include <linux/irqdomain.h>
#include <linux/kernel.h>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] extcon: sm5502: Drop useless include
2014-09-16 21:16 [PATCH] extcon: sm5502: Drop useless include Jean Delvare
@ 2014-09-22 7:01 ` Chanwoo Choi
0 siblings, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2014-09-22 7:01 UTC (permalink / raw)
To: Jean Delvare; +Cc: MyungJoo Ham, linux-kernel
On 09/17/2014 06:16 AM, Jean Delvare wrote:
> Don't include <linux/input.h> when the driver does not use anything
> from this header file.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Applied.
Thanks,
Chanwoo Choi
> ---
> drivers/extcon/extcon-sm5502.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/extcon/extcon-sm5502.c
> +++ b/drivers/extcon/extcon-sm5502.c
> @@ -17,7 +17,6 @@
>
> #include <linux/err.h>
> #include <linux/i2c.h>
> -#include <linux/input.h>
> #include <linux/interrupt.h>
> #include <linux/irqdomain.h>
> #include <linux/kernel.h>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] extcon: sm5502: Drop useless include
@ 2014-09-16 23:38 함명주
0 siblings, 0 replies; 3+ messages in thread
From: 함명주 @ 2014-09-16 23:38 UTC (permalink / raw)
To: Jean Delvare, 최찬우; +Cc: linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 934 bytes --]
> Don't include <linux/input.h> when the driver does not use anything
> from this header file.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Chanwoo, please review/merge the patch when you return.
Cheers,
MyungJoo
> ---
> drivers/extcon/extcon-sm5502.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/extcon/extcon-sm5502.c
> +++ b/drivers/extcon/extcon-sm5502.c
> @@ -17,7 +17,6 @@
>
> #include <linux/err.h>
> #include <linux/i2c.h>
> -#include <linux/input.h>
> #include <linux/interrupt.h>
> #include <linux/irqdomain.h>
> #include <linux/kernel.h>
>
> --
> Jean Delvare
> SUSE L3 Support
>
>
>
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-22 7:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-16 21:16 [PATCH] extcon: sm5502: Drop useless include Jean Delvare
2014-09-22 7:01 ` Chanwoo Choi
2014-09-16 23:38 함명주
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).