From: Sanchayan Maity <maitysanchayan@gmail.com>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: stefan@agner.ch, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: vf610-colibri: Add ADC support
Date: Fri, 26 Sep 2014 15:14:51 +0530 [thread overview]
Message-ID: <54253593.2060508@gmail.com> (raw)
In-Reply-To: <20140926020745.GH21077@dragon>
On Friday 26 September 2014 07:37 AM, Shawn Guo wrote:
> On Fri, Sep 19, 2014 at 04:56:13PM +0530, Sanchayan Maity wrote:
>> Enable ADC support for Colibri VF61 modules
>>
>> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
>> ---
>> arch/arm/boot/dts/vf610-colibri.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
>> index 0cd8343..6fd099e 100644
>> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
>> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
>> @@ -27,6 +27,16 @@
>>
>> };
>>
>> +&adc0 {
>> + pinctrl-names = "default";
>
> Sorry for missing it, but I would expect properties pinctrl-names and
> pinctrl-0 appear as a couple. Should we drop property pinctrl-names
> here?
>
> Shawn
We can actually drop this here. Vybrid has dedicated pads for 4 ADC channels.
Since we are using only these dedicated ADC channels, no pin multiplexing
is required. So we can drop the pinctrl-names property. Will clean and
send out a v3 patch. Thanks for pointing this out.
- Sanchayan
>
>> + status = "okay";
>> +};
>> +
>> +&adc1 {
>> + pinctrl-names = "default";
>> + status = "okay";
>> +};
>> +
>> &esdhc1 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_esdhc1>;
>> --
>> 1.7.9.5
>>
prev parent reply other threads:[~2014-09-26 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 11:26 [PATCH v2] Enable ADC support for Colibri VF61 modules Sanchayan Maity
2014-09-19 11:26 ` [PATCH v2] ARM: dts: vf610-colibri: Add ADC support Sanchayan Maity
2014-09-19 16:22 ` Stefan Agner
2014-09-26 2:07 ` Shawn Guo
2014-09-26 9:44 ` Sanchayan Maity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54253593.2060508@gmail.com \
--to=maitysanchayan@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=shawn.guo@freescale.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).