From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752051AbaI3G7v (ORCPT ); Tue, 30 Sep 2014 02:59:51 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbaI3G7u (ORCPT ); Tue, 30 Sep 2014 02:59:50 -0400 Message-ID: <542A54E4.2060407@nod.at> Date: Tue, 30 Sep 2014 08:59:48 +0200 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: "Bityutskiy, Artem" CC: "dedekind1@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH 4/4] UBI: Fastmap: Ensure that only one fastmap work is scheduled References: <1412029248-22454-1-git-send-email-richard@nod.at> <1412029248-22454-5-git-send-email-richard@nod.at> <1412059523.3904.11.camel@sauron.fi.intel.com> In-Reply-To: <1412059523.3904.11.camel@sauron.fi.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 30.09.2014 08:45, schrieb Bityutskiy, Artem: > On Tue, 2014-09-30 at 00:20 +0200, Richard Weinberger wrote: >> + spin_lock(&ubi->wl_lock); >> + ubi->fm_work_scheduled = 0; >> + spin_unlock(&ubi->wl_lock); > > Andrew Morton once said me that if I am protecting an integer change > like this with a spinlock, I have a problem in my locking design. He was > right for my particular case. > > Integer is changes atomic. The only other thing spinlock adds are the > barriers. I've added the spinlock to have a barrier in any case. Thanks, //richard