From: Guenter Roeck <linux@roeck-us.net>
To: Bjorn Helgaas <helgaas@kernel.org>,
Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: Linux 5.16-rc3
Date: Wed, 1 Dec 2021 12:50:02 -0800 [thread overview]
Message-ID: <542e38c7-afed-ebf5-5254-8aa6ee22b01a@roeck-us.net> (raw)
In-Reply-To: <20211201203822.GA2840039@bhelgaas>
On 12/1/21 12:38 PM, Bjorn Helgaas wrote:
> [+cc linux-pci]
>
> On Mon, Nov 29, 2021 at 01:18:12PM +0100, Sergio Paracuellos wrote:
>> On Mon, Nov 29, 2021 at 5:17 AM Guenter Roeck <linux@roeck-us.net> wrote:
>>> On 11/28/21 7:07 PM, Randy Dunlap wrote:
>>>> On 11/28/21 17:59, Guenter Roeck wrote:
>>>>> ...
>>>>> Build results:
>>>>> total: 153 pass: 152 fail: 1
>>>>> Failed builds:
>>>>> mips:allmodconfig
>>>>> Qemu test results:
>>>>> total: 482 pass: 482 fail: 0
>>>>>
>>>>> Building mips:allmodconfig ... failed
>>>>> --------------
>>>>> Error log:
>>>>> ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o
>>>>> ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
>>>>> ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
>>>>> ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
>>>>> ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined!
>>>>> ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
>>>>>
>>>>> There is still no fix for the mips:allmodconfig build problem as far
>>>>> as I can see. It is a bit odd, because the fix would be as simple as
>>>>>
>>>>> config PCIE_MT7621
>>>>> - tristate "MediaTek MT7621 PCIe Controller"
>>>>> - depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST)
>>>>> + bool "MediaTek MT7621 PCIe Controller"
>>>>> + depends on SOC_MT7621 || (MIPS && COMPILE_TEST)
>>>>> select PHY_MT7621_PCI
>>>>> default SOC_MT7621
>>>>> help
>>>>>
>>>>> Context: tristate doesn't make sense here because both RALINK and
>>>>> SOC_MT7621 are bool. Also, RALINK is redundant because SOC_MT7621
>>>>> already depends on it. The compile failure is due to missing exported
>>>>> symbols, and it is only seen if PCIE_MT7621=m - which is only possible
>>>>> if COMPILE_TEST=y. In other words, the dependencies above are set such
>>>>> that test builds, and only test builds, fail.
>>>>>
>>>>> The problem was introduced with commit 2bdd5238e756 ("PCI: mt7621:
>>>>> Add MediaTek MT7621 PCIe host controller driver"). Copying some of
>>>>> those responsible to see if we can expect a solution sometime soon.
>
> Can we do a minimal patch along the lines of the above for v5.16?
>
I would suggest to either do that or, if module support is mandatory,
revert the patch and re-apply it if and when it can be built as module.
Guenter
next prev parent reply other threads:[~2021-12-01 20:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-28 22:21 Linux 5.16-rc3 Linus Torvalds
2021-11-29 1:59 ` Guenter Roeck
2021-11-29 3:07 ` Randy Dunlap
2021-11-29 4:17 ` Guenter Roeck
2021-11-29 11:02 ` Lorenzo Pieralisi
2021-11-29 12:23 ` Sergio Paracuellos
2021-11-29 12:18 ` Sergio Paracuellos
2021-11-29 15:25 ` Guenter Roeck
2021-12-01 20:38 ` Bjorn Helgaas
2021-12-01 20:50 ` Guenter Roeck [this message]
2021-12-01 21:38 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542e38c7-afed-ebf5-5254-8aa6ee22b01a@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rdunlap@infradead.org \
--cc=sergio.paracuellos@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).