From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbaJJXqq (ORCPT ); Fri, 10 Oct 2014 19:46:46 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:50144 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567AbaJJXqo (ORCPT ); Fri, 10 Oct 2014 19:46:44 -0400 Message-ID: <5436E1E7.8080309@kernel.org> Date: Thu, 09 Oct 2014 20:28:39 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Daniel Baluta CC: linux-iio@vger.kernel.org, Linux Kernel Mailing List , irina.tirdea@intel.com Subject: Re: [RFC PATCH 1/8] iio: dummy: Introduce virtual registers for dummy device References: <1412257439-15683-1-git-send-email-daniel.baluta@intel.com> <1412257439-15683-2-git-send-email-daniel.baluta@intel.com> <542FECB4.5010001@kernel.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/14 12:17, Daniel Baluta wrote: > On Sat, Oct 4, 2014 at 3:48 PM, Jonathan Cameron wrote: >> On 02/10/14 14:43, Daniel Baluta wrote: >>> We need a way to store events generated by iio_dummy_evgen module, >>> in order to correctly process IRQs in iio_simple_dummy_events. >>> >>> For the moment, we add two registers: >>> >>> * id_reg - ID register, stores the source of the event >>> * id_data - DATA register, stores the type of the event >>> >>> e.g echo 4 > /sys/bus/iio/devices/iio_evgen/poke2 >>> >>> id_reg 0x02, id_data 0x04 >>> >>> This means, event of type 4 was generated by fake device 2. >>> >>> We currently use a hardcoded mapping of virtual events to IIO events. >>> >>> Signed-off-by: Daniel Baluta >>> Signed-off-by: Irina Tirdea >> Does the job and will look enough like a normal interrupt that >> it allows the dummy driver to act as example code. > > Hi Jonathan, > > Thanks for the reviews. > > This patch is self contained and it could be merged > separately if you think it's stable enough. Given there's no rush I'll wait for the whole series. > > We are going over your reviews for the other patches and will send v2 > as soon as possible. > > Daniel. >