linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Manfred Schlaegl <manfred.schlaegl@gmx.at>,
	Jeff Dike <jdike@addtoit.com>
Cc: Daniel Walter <dwalter@google.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	user-mode-linux-devel@lists.sourceforge.net,
	user-mode-linux-user@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] um: Remove unused bp stack-frame pointer
Date: Sat, 18 Oct 2014 17:19:28 +0200	[thread overview]
Message-ID: <54428500.6020304@nod.at> (raw)
In-Reply-To: <54428348.2050209@gmx.at>

Am 18.10.2014 um 17:12 schrieb Manfred Schlaegl:
> On 2014-10-18 16:42, Richard Weinberger wrote:
>> Am 18.10.2014 um 16:23 schrieb Manfred Schlaegl:
>>> The pointer to bp stack-frame is no longer used. Removed it.
>>
>> Good catch!
> Thank you.
> 
>>
>>> This also removes a corresponding compiler-warning.
>>
>> Which warning exactly?
> 
> On "normal" (defconfig) builds the warning does not show up because CONFIG_FRAME_POINTER is set.
> I've found the unused bp because CONFIG_FRAME_POINTER was not set in my configuration.
> 
>   CC      arch/um/kernel/sysrq.o
> arch/um/kernel/sysrq.c: In function ‘show_stack’:
> arch/um/kernel/sysrq.c:32:29: warning: unused variable ‘bp’ [-Wunused-variable]

Looks like my gcc need's an upgrade. :D

Thanks,
//richard

  reply	other threads:[~2014-10-18 15:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-18 14:23 [PATCH] um: Remove unused bp stack-frame pointer Manfred Schlaegl
2014-10-18 14:42 ` Richard Weinberger
2014-10-18 15:12   ` Manfred Schlaegl
2014-10-18 15:19     ` Richard Weinberger [this message]
2014-10-18 15:24       ` Manfred Schlaegl
2014-10-18 15:40         ` Richard Weinberger
2014-10-19 17:28           ` Manfred Schlaegl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54428500.6020304@nod.at \
    --to=richard@nod.at \
    --cc=dwalter@google.com \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred.schlaegl@gmx.at \
    --cc=rdunlap@infradead.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --cc=user-mode-linux-user@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).