From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@redhat.com>, Vojtech Pavlik <vojtech@suse.cz>,
Jiri Kosina <jkosina@suse.cz>, Jiri Slaby <jslaby@suse.cz>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] kprobes: introduce ARCH_HANDLES_KPROBES_ON_FTRACE
Date: Tue, 21 Oct 2014 10:51:31 +0900 [thread overview]
Message-ID: <5445BC23.6080207@hitachi.com> (raw)
In-Reply-To: <20141020145321.0af7a4dd@gandalf.local.home>
(2014/10/21 3:53), Steven Rostedt wrote:
> On Mon, 20 Oct 2014 10:55:30 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>
>
>> Hmm, this looks a bit not straight. Maybe we'd better introduce a local
>> check_ftrace_location() function which always returns 0 if
>> CONFIG_ARCH_HANDLES_KPROBES_ON_FTRACE(with a comment! :)) as below.
>>
>> int check_ftrace_location(kp)
>> {
>> unsigned long ftrace_address;
>>
>> /* If an architecture handles kprobes on ftrace, we don't check it */
>> if (IS_ENABLED(CONFIG_ARCH_HANDLES_KPROBES_ON_FTRACE))
>> return 0;
>>
>> ...
>> }
>
> We can also just make that function weak, and let the archs override
> the default behavior?
Ah, that will be simpler and we don't need new Kconfig.
Thank you!
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2014-10-21 1:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 15:46 [PATCH 0/2] s390 vs. kprobes on ftrace Heiko Carstens
2014-10-15 15:46 ` [PATCH 1/2] kprobes: introduce ARCH_HANDLES_KPROBES_ON_FTRACE Heiko Carstens
2014-10-20 1:55 ` Masami Hiramatsu
2014-10-20 18:53 ` Steven Rostedt
2014-10-21 1:51 ` Masami Hiramatsu [this message]
2014-10-15 15:46 ` [PATCH 2/2] s390/ftrace,kprobes: allow to patch first instruction Heiko Carstens
2014-10-16 5:49 ` [PATCH 0/2] s390 vs. kprobes on ftrace Masami Hiramatsu
2014-10-16 10:57 ` Heiko Carstens
2014-10-21 9:37 ` Masami Hiramatsu
2014-10-17 8:19 ` Heiko Carstens
2014-10-17 8:28 ` Heiko Carstens
2014-10-20 2:02 ` Masami Hiramatsu
2014-10-20 6:41 ` Heiko Carstens
2014-10-17 8:21 ` Heiko Carstens
2014-10-20 1:31 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5445BC23.6080207@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=jkosina@suse.cz \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=schwidefsky@de.ibm.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).