From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932705AbaJVJdu (ORCPT ); Wed, 22 Oct 2014 05:33:50 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:33325 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932436AbaJVJds (ORCPT ); Wed, 22 Oct 2014 05:33:48 -0400 Message-ID: <544779F8.2040505@imgtec.com> Date: Wed, 22 Oct 2014 10:33:44 +0100 From: Qais Yousef User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.0 MIME-Version: 1.0 To: Andrew Bresticker CC: Ralf Baechle , Daniel Lezcano , Thomas Gleixner , "Jason Cooper" , Paul Burton , "John Crispin" , , Subject: Re: [PATCH 03/19] MIPS: sead3: Stop using GIC REG macros References: <1413831846-32100-1-git-send-email-abrestic@chromium.org> <1413831846-32100-4-git-send-email-abrestic@chromium.org> In-Reply-To: <1413831846-32100-4-git-send-email-abrestic@chromium.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/20/2014 08:03 PM, Andrew Bresticker wrote: > Stop using the REG macros from gic.h and instead use proper iomem > accessors. > > Signed-off-by: Andrew Bresticker > --- > arch/mips/mti-sead3/sead3-int.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/mips/mti-sead3/sead3-int.c b/arch/mips/mti-sead3/sead3-int.c > index 69ae185..995c401 100644 > --- a/arch/mips/mti-sead3/sead3-int.c > +++ b/arch/mips/mti-sead3/sead3-int.c > @@ -20,16 +20,15 @@ > #define SEAD_CONFIG_BASE 0x1b100110 > #define SEAD_CONFIG_SIZE 4 > > -static unsigned long sead3_config_reg; > +static void __iomem *sead3_config_reg; > > void __init arch_init_irq(void) > { > if (!cpu_has_veic) > mips_cpu_irq_init(); > > - sead3_config_reg = (unsigned long)ioremap_nocache(SEAD_CONFIG_BASE, > - SEAD_CONFIG_SIZE); > - gic_present = (REG32(sead3_config_reg) & SEAD_CONFIG_GIC_PRESENT_MSK) >> > + sead3_config_reg = ioremap_nocache(SEAD_CONFIG_BASE, SEAD_CONFIG_SIZE); > + gic_present = (readl(sead3_config_reg) & SEAD_CONFIG_GIC_PRESENT_MSK) >> > SEAD_CONFIG_GIC_PRESENT_SHF; > pr_info("GIC: %spresent\n", (gic_present) ? "" : "not "); > pr_info("EIC: %s\n", I think you need to use the __raw_readl() variant here and for all other similar changes. Qais