From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751578AbaKESMm (ORCPT ); Wed, 5 Nov 2014 13:12:42 -0500 Received: from mail-ob0-f182.google.com ([209.85.214.182]:56402 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751491AbaKESMj (ORCPT ); Wed, 5 Nov 2014 13:12:39 -0500 Message-ID: <545A6894.7040506@lwfinger.net> Date: Wed, 05 Nov 2014 12:12:36 -0600 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Mike Galbraith CC: Murilo Opsfelder Araujo , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Chaoming Li , "John W. Linville" , Thadeu Cascardo , troy_tan@realsil.com.cn Subject: Re: [PATCH] rtlwifi: Add more checks for get_btc_status callback References: <1414625302-3654-1-git-send-email-mopsfelder@gmail.com> <5451BED0.2060906@lwfinger.net> <1415178975.5402.66.camel@marge.simpson.net> In-Reply-To: <1415178975.5402.66.camel@marge.simpson.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/05/2014 03:16 AM, Mike Galbraith wrote: > On Wed, 2014-10-29 at 23:30 -0500, Larry Finger wrote: >> On 10/29/2014 06:28 PM, Murilo Opsfelder Araujo wrote: >>> This is a complement of commit 08054200117a95afc14c3d2ed3a38bf4e345bf78 >>> "rtlwifi: Add check for get_btc_status callback". >>> >>> With this patch, next-20141029 at least does not panic with rtl8192se >>> device. >>> >> >> This patch is OK, but as noted it is not complete. >> >> I have patches to fix all the kernel panics for rtl8192se AND rtl8192ce. There >> are missing parts, but I would prefer submitting mine, which would conflict with >> this one. For that reason, NACK for this one, and please apply the set I am >> submitting now. > > It's all in there now, but my RTL8191SEvB is still dead. Squabbling > with it isn't going all that well either. > > As soon as 38506ece rtlwifi: rtl_pci: Start modification for new drivers > is applied, explosions appear. Subsequently applying... > > 08054200 rtlwifi: Add check for get_btc_status callback > c0386f15 rtlwifi: rtl8192ce: rtl8192de: rtl8192se: Fix handling for missing get_btc_status > 50147969 rtlwifi: rtl8192se: Fix duplicate calls to ieee80211_register_hw() > 30c5ccc6 rtlwifi: rtl8192se: Add missing section to read descriptor setting > 75a916e1 rtlwifi: rtl8192se: Fix firmware loading > > ...fixes that mess up, but leaves the interface dead in the same manner > as if nothing has been reverted. So it _seems_ the bustage lurks in > 38506ece somewhere. Too bad it's non-dinky, and written in wifi-ese :) Yes, I am aware that rtl8192se is failing, and now that I am back from vacation, I am working on the problem. If you want to use the driver with kernel 3.18, clone the repo at http://github.com/lwfinger/rtlwifi_new.git and build and install either the master or kernel_version branches. Both work. I am in the process of trying to find what the crucial difference is between that repo and the kernel version. Larry