From: Vlastimil Babka <vbabka@suse.cz>
To: Steven Noonan <steven@uplinklabs.net>, linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] compiler-gcc*.h: remove inaccurate comment about 'asm goto' miscompiles
Date: Thu, 06 Nov 2014 15:44:27 +0100 [thread overview]
Message-ID: <545B894B.90602@suse.cz> (raw)
In-Reply-To: <1414274982-14040-1-git-send-email-steven@uplinklabs.net>
On 10/26/2014 12:09 AM, Steven Noonan wrote:
> The bug referenced by the comment in this commit was not completely fixed in
> GCC 4.8.2, as I mentioned in a thread back in February[1]. The conclusion at
> that time was to make the quirk unconditional until the bug could be found and
> fixed in GCC. Unfortunately, when I submitted the patch (commit a9f18034)
> I left a comment in that claimed the bug was fixed in GCC 4.8.2+. This comment
> is inaccurate, and should be removed.
I believe the original gcc bug was indeed fixed, but there's another bug [1] not
yet fixed, see also [2]. So maybe the new bug number should be added to the
comments?
Vlastimil
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61772
[2] https://lkml.org/lkml/2014/7/10/398
> [1] https://lkml.org/lkml/2014/2/12/797
> Signed-off-by: Steven Noonan <steven@uplinklabs.net>
> Cc: Ingo Molnar <mingo@kernel.org>
> ---
> include/linux/compiler-gcc4.h | 1 -
> include/linux/compiler-gcc5.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/include/linux/compiler-gcc4.h b/include/linux/compiler-gcc4.h
> index 2507fd2..d1a5582 100644
> --- a/include/linux/compiler-gcc4.h
> +++ b/include/linux/compiler-gcc4.h
> @@ -71,7 +71,6 @@
> * http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58670
> *
> * Work it around via a compiler barrier quirk suggested by Jakub Jelinek.
> - * Fixed in GCC 4.8.2 and later versions.
> *
> * (asm goto is automatically volatile - the naming reflects this.)
> */
> diff --git a/include/linux/compiler-gcc5.h b/include/linux/compiler-gcc5.h
> index cdd1cc2..c8c5659 100644
> --- a/include/linux/compiler-gcc5.h
> +++ b/include/linux/compiler-gcc5.h
> @@ -53,7 +53,6 @@
> * http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58670
> *
> * Work it around via a compiler barrier quirk suggested by Jakub Jelinek.
> - * Fixed in GCC 4.8.2 and later versions.
> *
> * (asm goto is automatically volatile - the naming reflects this.)
> */
>
prev parent reply other threads:[~2014-11-06 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-25 22:09 [PATCH] compiler-gcc*.h: remove inaccurate comment about 'asm goto' miscompiles Steven Noonan
2014-10-28 11:12 ` [tip:core/urgent] compiler/gcc4+: Remove " tip-bot for Steven Noonan
2014-11-06 14:44 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545B894B.90602@suse.cz \
--to=vbabka@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=steven@uplinklabs.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).