From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752986AbaKKKuq (ORCPT ); Tue, 11 Nov 2014 05:50:46 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:14770 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603AbaKKKup (ORCPT ); Tue, 11 Nov 2014 05:50:45 -0500 X-IronPort-AV: E=Sophos;i="5.07,360,1413244800"; d="scan'208";a="191510545" Message-ID: <5461EA02.3020400@citrix.com> Date: Tue, 11 Nov 2014 10:50:42 +0000 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Juergen Gross , , , , , , , , Subject: Re: [Xen-devel] [PATCH V3 1/8] xen: Make functions static References: <1415684626-18590-1-git-send-email-jgross@suse.com> <1415684626-18590-2-git-send-email-jgross@suse.com> <5461E310.4070803@citrix.com> <5461E698.9060904@suse.com> In-Reply-To: <5461E698.9060904@suse.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/14 10:36, Juergen Gross wrote: > On 11/11/2014 11:21 AM, David Vrabel wrote: >> On 11/11/14 05:43, Juergen Gross wrote: >>> Some functions in arch/x86/xen/p2m.c are used locally only. Make them >>> static. Rearrange the functions in p2m.c to avoid forward declarations. >>> >>> While at it correct some style issues (long lines, use pr_warn()). >> >> Please don't add extra stuff like this. In general if you feel yourself >> wring "while at it..." or "also..." then you need another patch. > > I applied the changes only to functions I was moving, as checkpatch was > complaining. Documentation says this should be avoided only when moving > functions between files. If the documentation says that then it is wrong. Fix the style issues in one patch and then move the functions in another. David