From: "Jürgen Groß" <jgross@suse.com>
To: David Vrabel <david.vrabel@citrix.com>,
linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
konrad.wilk@oracle.com, boris.ostrovsky@oracle.com,
x86@kernel.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com
Subject: Re: [Xen-devel] [PATCH V3 1/8] xen: Make functions static
Date: Tue, 11 Nov 2014 11:55:51 +0100 [thread overview]
Message-ID: <5461EB37.4010603@suse.com> (raw)
In-Reply-To: <5461EA02.3020400@citrix.com>
On 11/11/2014 11:50 AM, David Vrabel wrote:
> On 11/11/14 10:36, Juergen Gross wrote:
>> On 11/11/2014 11:21 AM, David Vrabel wrote:
>>> On 11/11/14 05:43, Juergen Gross wrote:
>>>> Some functions in arch/x86/xen/p2m.c are used locally only. Make them
>>>> static. Rearrange the functions in p2m.c to avoid forward declarations.
>>>>
>>>> While at it correct some style issues (long lines, use pr_warn()).
>>>
>>> Please don't add extra stuff like this. In general if you feel yourself
>>> wring "while at it..." or "also..." then you need another patch.
>>
>> I applied the changes only to functions I was moving, as checkpatch was
>> complaining. Documentation says this should be avoided only when moving
>> functions between files.
>
> If the documentation says that then it is wrong. Fix the style issues
> in one patch and then move the functions in another.
Okay.
Juergen
next prev parent reply other threads:[~2014-11-11 10:55 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 5:43 [PATCH V3 0/8] xen: Switch to virtual mapped linear p2m list Juergen Gross
2014-11-11 5:43 ` [PATCH V3 1/8] xen: Make functions static Juergen Gross
2014-11-11 10:21 ` [Xen-devel] " David Vrabel
2014-11-11 10:36 ` Juergen Gross
2014-11-11 10:50 ` David Vrabel
2014-11-11 10:55 ` Jürgen Groß [this message]
2014-11-11 5:43 ` [PATCH V3 2/8] xen: Delay remapping memory of pv-domain Juergen Gross
2014-11-11 11:45 ` [Xen-devel] " Andrew Cooper
2014-11-11 12:03 ` Juergen Gross
2014-11-12 21:45 ` Konrad Rzeszutek Wilk
2014-11-13 6:23 ` Juergen Gross
2014-11-13 19:56 ` Konrad Rzeszutek Wilk
2014-11-14 4:53 ` Juergen Gross
2014-11-14 11:16 ` [Xen-devel] " David Vrabel
2014-11-14 16:47 ` Konrad Rzeszutek Wilk
2014-11-14 17:14 ` Juergen Gross
2014-11-19 19:43 ` Konrad Rzeszutek Wilk
2014-11-20 4:59 ` Juergen Gross
2014-11-11 5:43 ` [PATCH V3 3/8] xen: Delay m2p_override initialization Juergen Gross
2014-11-11 10:29 ` [Xen-devel] " David Vrabel
2014-11-12 18:35 ` Konrad Rzeszutek Wilk
2014-11-11 5:43 ` [PATCH V3 4/8] xen: Delay invalidating extra memory Juergen Gross
2014-11-12 22:10 ` Konrad Rzeszutek Wilk
2014-11-13 6:49 ` Juergen Gross
2014-11-13 19:56 ` Konrad Rzeszutek Wilk
2014-11-11 5:43 ` [PATCH V3 5/8] x86: Introduce function to get pmd entry pointer Juergen Gross
2014-11-12 22:12 ` Konrad Rzeszutek Wilk
2014-11-13 6:54 ` Juergen Gross
2014-11-13 20:01 ` Konrad Rzeszutek Wilk
2014-11-11 5:43 ` [PATCH V3 6/8] xen: Hide get_phys_to_machine() to be able to tune common path Juergen Gross
2014-11-11 17:38 ` [Xen-devel] " David Vrabel
2014-11-12 22:18 ` Konrad Rzeszutek Wilk
2014-11-13 9:15 ` Juergen Gross
2014-11-13 13:51 ` Konrad Rzeszutek Wilk
2014-11-11 5:43 ` [PATCH V3 7/8] xen: switch to linear virtual mapped sparse p2m list Juergen Gross
2014-11-11 17:47 ` [Xen-devel] " David Vrabel
2014-11-13 9:21 ` Juergen Gross
2014-11-14 11:58 ` David Vrabel
2014-11-14 12:42 ` Juergen Gross
2014-11-19 20:38 ` Konrad Rzeszutek Wilk
2014-11-19 20:37 ` Konrad Rzeszutek Wilk
2014-11-11 5:43 ` [PATCH V3 8/8] xen: Speed up set_phys_to_machine() by using read-only mappings Juergen Gross
2014-11-11 17:48 ` [Xen-devel] " David Vrabel
2014-11-19 20:39 ` Konrad Rzeszutek Wilk
2014-11-19 20:41 ` [PATCH V3 0/8] xen: Switch to virtual mapped linear p2m list Konrad Rzeszutek Wilk
2014-11-20 5:08 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5461EB37.4010603@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).