From: Arnd Bergmann <arnd@arndb.de>
To: Jiri Pirko <jiri@resnulli.us>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexander Duyck <aduyck@mirantis.com>,
Tom Herbert <tom@herbertland.com>, Jiri Pirko <jiri@mellanox.com>,
Hadar Hen Zion <hadarh@mellanox.com>,
Gao Feng <fgao@48lvckh6395k16k5.yundunddos.com>,
Eric Garver <e@erig.me>, Amir Vadai <amir@vadai.me>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] flow_dissector: avoid uninitialized variable access
Date: Fri, 21 Oct 2016 23:05:45 +0200 [thread overview]
Message-ID: <5467015.N4DG5uA0DU@wuerfel> (raw)
In-Reply-To: <20161021163118.GA2155@nanopsycho.orion>
On Friday, October 21, 2016 6:31:18 PM CEST Jiri Pirko wrote:
> Fri, Oct 21, 2016 at 05:55:53PM CEST, arnd@arndb.de wrote:
> >gcc warns about an uninitialized pointer dereference in the vlan
> >priority handling:
> >
> >net/core/flow_dissector.c: In function '__skb_flow_dissect':
> >net/core/flow_dissector.c:281:61: error: 'vlan' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> >
> >From all I can tell, this warning is about a real bug, and we
> >should not attempt look up the vlan header if there was
> >no vlan tag.
>
> I don't see how vlan could be used uninitialized. But I understand that
> this is impossible for gcc to track it. Please just use uninitialized_var()
>
I usually try to avoid uninitialized_var(), as making it obvious to
the compiler why something is known tends to result in more readable
source code and better object code.
Can you explain why "dissector_uses_key(flow_dissector,
FLOW_DISSECTOR_KEY_VLAN) && skb_vlan_tag_present(skb)" implies
"eth_type_vlan(proto))"?
If I add uninitialized_var() here, I would at least put that in
a comment here.
On a related note, I also don't see how
"dissector_uses_key(flow_dissector, FLOW_DISSECTOR_KEY_VLAN)"
implies that skb is non-NULL. I guess this is related to the
first one.
Arnd
next prev parent reply other threads:[~2016-10-21 21:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 15:55 [PATCH] flow_dissector: avoid uninitialized variable access Arnd Bergmann
2016-10-21 16:31 ` Jiri Pirko
2016-10-21 21:05 ` Arnd Bergmann [this message]
2016-10-21 22:16 ` Arnd Bergmann
2016-10-22 15:57 ` Eric Garver
2016-10-22 18:20 ` Tom Herbert
2016-10-22 20:30 ` [PATCH net-next] flow_dissector: fix vlan tag handling Arnd Bergmann
2016-10-24 8:17 ` Jiri Pirko
2016-10-24 16:00 ` Arnd Bergmann
2016-10-22 1:48 ` [PATCH] flow_dissector: avoid uninitialized variable access Linus Torvalds
2016-10-22 6:55 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5467015.N4DG5uA0DU@wuerfel \
--to=arnd@arndb.de \
--cc=aduyck@mirantis.com \
--cc=amir@vadai.me \
--cc=davem@davemloft.net \
--cc=e@erig.me \
--cc=fgao@48lvckh6395k16k5.yundunddos.com \
--cc=hadarh@mellanox.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).