From: Michael Walle <michael@walle.cc>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
Alex Marginean <alexandru.marginean@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Heiko Thiery <heiko.thiery@gmail.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next v6 1/4] net: phy: add USXGMII link partner ability constants
Date: Mon, 13 Jul 2020 20:37:01 +0200 [thread overview]
Message-ID: <546718f3f76862d285aeb82cb02767c4@walle.cc> (raw)
In-Reply-To: <20200713182314.GW1551@shell.armlinux.org.uk>
Am 2020-07-13 20:23, schrieb Russell King - ARM Linux admin:
> On Thu, Jul 09, 2020 at 11:35:23PM +0200, Michael Walle wrote:
>> The constants are taken from the USXGMII Singleport Copper Interface
>> specification. The naming are based on the SGMII ones, but with an
>> MDIO_
>> prefix.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> include/uapi/linux/mdio.h | 26 ++++++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>>
>> diff --git a/include/uapi/linux/mdio.h b/include/uapi/linux/mdio.h
>> index 4bcb41c71b8c..784723072578 100644
>> --- a/include/uapi/linux/mdio.h
>> +++ b/include/uapi/linux/mdio.h
>> @@ -324,4 +324,30 @@ static inline __u16 mdio_phy_id_c45(int prtad,
>> int devad)
>> return MDIO_PHY_ID_C45 | (prtad << 5) | devad;
>> }
>>
>> +/* UsxgmiiChannelInfo[15:0] for USXGMII in-band auto-negotiation.*/
>> +#define MDIO_LPA_USXGMII_EEE_CLK_STP 0x0080 /* EEE clock stop
>> supported */
>> +#define MDIO_LPA_USXGMII_EEE 0x0100 /* EEE supported */
>> +#define MDIO_LPA_USXGMII_SPD_MASK 0x0e00 /* USXGMII speed mask */
>> +#define MDIO_LPA_USXGMII_FULL_DUPLEX 0x1000 /* USXGMII full duplex */
>> +#define MDIO_LPA_USXGMII_DPX_SPD_MASK 0x1e00 /* USXGMII duplex and
>> speed bits */
>> +#define MDIO_LPA_USXGMII_10 0x0000 /* 10Mbps */
>> +#define MDIO_LPA_USXGMII_10HALF 0x0000 /* 10Mbps half-duplex */
>> +#define MDIO_LPA_USXGMII_10FULL 0x1000 /* 10Mbps full-duplex */
>> +#define MDIO_LPA_USXGMII_100 0x0200 /* 100Mbps */
>> +#define MDIO_LPA_USXGMII_100HALF 0x0200 /* 100Mbps half-duplex */
>> +#define MDIO_LPA_USXGMII_100FULL 0x1200 /* 100Mbps full-duplex */
>> +#define MDIO_LPA_USXGMII_1000 0x0400 /* 1000Mbps */
>> +#define MDIO_LPA_USXGMII_1000HALF 0x0400 /* 1000Mbps half-duplex */
>> +#define MDIO_LPA_USXGMII_1000FULL 0x1400 /* 1000Mbps full-duplex */
>> +#define MDIO_LPA_USXGMII_10G 0x0600 /* 10Gbps */
>> +#define MDIO_LPA_USXGMII_10GHALF 0x0600 /* 10Gbps half-duplex */
>> +#define MDIO_LPA_USXGMII_10GFULL 0x1600 /* 10Gbps full-duplex */
>> +#define MDIO_LPA_USXGMII_2500 0x0800 /* 2500Mbps */
>> +#define MDIO_LPA_USXGMII_2500HALF 0x0800 /* 2500Mbps half-duplex */
>> +#define MDIO_LPA_USXGMII_2500FULL 0x1800 /* 2500Mbps full-duplex */
>> +#define MDIO_LPA_USXGMII_5000 0x0a00 /* 5000Mbps */
>> +#define MDIO_LPA_USXGMII_5000HALF 0x0a00 /* 5000Mbps half-duplex */
>> +#define MDIO_LPA_USXGMII_5000FULL 0x1a00 /* 5000Mbps full-duplex */
>> +#define MDIO_LPA_USXGMII_LINK 0x8000 /* PHY link with copper-side
>> partner */
>
> btw, the only thing which is missing from this is bit 0.
TBH, I didn't know how to name it. Any suggestions?
> One other point - in the USXGMII specification, this appears to be
> somewhat symmetrical - the same definitions are listed as being
> used for PHY to MAC as for MAC to PHY (presumably as part of the
> acknowledgement that the MAC actually switched to that speed.)
> So, it probably makes sense to drop the LPA_ infix.
Ok. I'll send a new version, once we have a name for bit 0.
-michael
next prev parent reply other threads:[~2020-07-13 18:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 21:35 [PATCH net-next v6 0/4] net: enetc: remove bootloader dependency Michael Walle
2020-07-09 21:35 ` [PATCH net-next v6 1/4] net: phy: add USXGMII link partner ability constants Michael Walle
2020-07-13 16:34 ` Vladimir Oltean
2020-07-13 17:01 ` Andrew Lunn
2020-07-13 17:07 ` Michael Walle
2020-07-13 18:16 ` Russell King - ARM Linux admin
2020-07-13 18:23 ` Russell King - ARM Linux admin
2020-07-13 18:37 ` Michael Walle [this message]
2020-07-15 20:33 ` Michael Walle
2020-07-15 22:44 ` Vladimir Oltean
2020-07-16 7:49 ` Michael Walle
2020-07-09 21:35 ` [PATCH net-next v6 2/4] net: dsa: felix: (re)use already existing constants Michael Walle
2020-07-13 16:33 ` Vladimir Oltean
2020-07-09 21:35 ` [PATCH net-next v6 3/4] net: enetc: Initialize SerDes for SGMII and USXGMII protocols Michael Walle
2020-07-13 16:38 ` Vladimir Oltean
2020-07-09 21:35 ` [PATCH net-next v6 4/4] net: enetc: Use DT protocol information to set up the ports Michael Walle
2020-07-13 16:39 ` Vladimir Oltean
2020-07-11 7:52 ` [PATCH net-next v6 0/4] net: enetc: remove bootloader dependency Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546718f3f76862d285aeb82cb02767c4@walle.cc \
--to=michael@walle.cc \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandru.marginean@nxp.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=heiko.thiery@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).