From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755235AbaKPKKA (ORCPT ); Sun, 16 Nov 2014 05:10:00 -0500 Received: from cantor2.suse.de ([195.135.220.15]:35000 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754676AbaKPKJ5 (ORCPT ); Sun, 16 Nov 2014 05:09:57 -0500 Message-ID: <546877EF.8010906@suse.de> Date: Sun, 16 Nov 2014 11:09:51 +0100 From: =?windows-1252?Q?Andreas_F=E4rber?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Pavel Machek CC: pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, freemangordon@abv.bg, bcousson@baylibre.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sakari.ailus@iki.fi, devicetree@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [RFC] adp1653: Add device tree bindings for LED controller References: <20141116075928.GA9763@amd> In-Reply-To: <20141116075928.GA9763@amd> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, Am 16.11.2014 um 08:59 schrieb Pavel Machek: > For device tree people: Yes, I know I'll have to create file in > documentation, but does the binding below look acceptable? [...] > diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts > index 739fcf2..ed0bfc1 100644 > --- a/arch/arm/boot/dts/omap3-n900.dts > +++ b/arch/arm/boot/dts/omap3-n900.dts > @@ -553,6 +561,18 @@ > > ti,usb-charger-detection = <&isp1704>; > }; > + > + adp1653: adp1653@30 { This should probably be led-controller@30 (a generic description not specific to the model). The label name is fine. > + compatible = "ad,adp1653"; > + reg = <0x30>; > + > + max-flash-timeout-usec = <500000>; > + max-flash-intensity-uA = <320000>; > + max-torch-intensity-uA = <50000>; > + max-indicator-intensity-uA = <17500>; > + > + gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* Want 88 */ At least to me, the meaning of "Want 88" is not clear - drop or clarify? > + }; > }; > > &i2c3 { [snip] Regards, Andreas -- SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg