From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752849AbaKQF20 (ORCPT ); Mon, 17 Nov 2014 00:28:26 -0500 Received: from mail7.hitachi.co.jp ([133.145.228.42]:59603 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752413AbaKQF2Z (ORCPT ); Mon, 17 Nov 2014 00:28:25 -0500 Message-ID: <54698771.4060705@hitachi.com> Date: Mon, 17 Nov 2014 14:28:17 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Jiri Kosina , Petr Mladek , Namhyung Kim , Srikar Dronamraju Subject: Re: [PATCH 10/26 v5] tracing/uprobes: Do not use return values of trace_seq_printf() References: <20141115045847.712848224@goodmis.org> <20141115050602.333705855@goodmis.org> In-Reply-To: <20141115050602.333705855@goodmis.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2014/11/15 13:58), Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > The functions trace_seq_printf() and friends will soon no longer have > return values. Using trace_seq_has_overflowed() and trace_handle_return() > should be used instead. > > Link: http://lkml.kernel.org/r/20141114011411.693008134@goodmis.org > This looks good to me :) Reviewed-by: Masami Hiramatsu > Cc: Masami Hiramatsu > Cc: Namhyung Kim > Cc: Srikar Dronamraju > Signed-off-by: Steven Rostedt > --- > kernel/trace/trace_uprobe.c | 23 ++++++++++------------- > 1 file changed, 10 insertions(+), 13 deletions(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index e35327c787f7..fd76f8e108ef 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -852,16 +852,14 @@ print_uprobe_event(struct trace_iterator *iter, int flags, struct trace_event *e > tu = container_of(event, struct trace_uprobe, tp.call.event); > > if (is_ret_probe(tu)) { > - if (!trace_seq_printf(s, "%s: (0x%lx <- 0x%lx)", > - ftrace_event_name(&tu->tp.call), > - entry->vaddr[1], entry->vaddr[0])) > - goto partial; > + trace_seq_printf(s, "%s: (0x%lx <- 0x%lx)", > + ftrace_event_name(&tu->tp.call), > + entry->vaddr[1], entry->vaddr[0]); > data = DATAOF_TRACE_ENTRY(entry, true); > } else { > - if (!trace_seq_printf(s, "%s: (0x%lx)", > - ftrace_event_name(&tu->tp.call), > - entry->vaddr[0])) > - goto partial; > + trace_seq_printf(s, "%s: (0x%lx)", > + ftrace_event_name(&tu->tp.call), > + entry->vaddr[0]); > data = DATAOF_TRACE_ENTRY(entry, false); > } > > @@ -869,14 +867,13 @@ print_uprobe_event(struct trace_iterator *iter, int flags, struct trace_event *e > struct probe_arg *parg = &tu->tp.args[i]; > > if (!parg->type->print(s, parg->name, data + parg->offset, entry)) > - goto partial; > + goto out; > } > > - if (trace_seq_putc(s, '\n')) > - return TRACE_TYPE_HANDLED; > + trace_seq_putc(s, '\n'); > > -partial: > - return TRACE_TYPE_PARTIAL_LINE; > + out: > + return trace_handle_return(s); > } > > typedef bool (*filter_func_t)(struct uprobe_consumer *self, -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com