From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754736AbaKRSA3 (ORCPT ); Tue, 18 Nov 2014 13:00:29 -0500 Received: from mout.web.de ([212.227.17.11]:56227 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754523AbaKRSAW (ORCPT ); Tue, 18 Nov 2014 13:00:22 -0500 Message-ID: <546B8929.9010409@users.sourceforge.net> Date: Tue, 18 Nov 2014 19:00:09 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Jan Kara CC: LKML , kernel-janitors@vger.kernel.org, Coccinelle Subject: [PATCH 1/2] fs-udf: Deletion of unnecessary checks before the function call "iput" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546B8814.2030701@users.sourceforge.net> In-Reply-To: <546B8814.2030701@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Qd5qJFvCpxbwA/dhY/9BIyg17EeJ22ItPfKNqjvuweayFHP2x1c CpqG/hIRbrZdRQFEZxwiTxHCwJifCePMDlEWQRg+hiicb/lB4eKyu1aI/gIqSvjdj27rZvG I4eOucbHNA5YmpSasRw4d3xy724DddSuQ5Y5fRbD8VeR70ojuF1L2Jy+JazNPrQ5rQzr1Cx ZORIoB/unSjKOVYav6XCQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 18 Nov 2014 17:17:46 +0100 The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/udf/super.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/udf/super.c b/fs/udf/super.c index e229315..f93c65d 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -2237,8 +2237,7 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent) return 0; error_out: - if (sbi->s_vat_inode) - iput(sbi->s_vat_inode); + iput(sbi->s_vat_inode); #ifdef CONFIG_UDF_NLS if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP)) unload_nls(sbi->s_nls_map); @@ -2291,8 +2290,7 @@ static void udf_put_super(struct super_block *sb) sbi = UDF_SB(sb); - if (sbi->s_vat_inode) - iput(sbi->s_vat_inode); + iput(sbi->s_vat_inode); #ifdef CONFIG_UDF_NLS if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP)) unload_nls(sbi->s_nls_map); -- 2.1.3