From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755764AbaKSBKH (ORCPT ); Tue, 18 Nov 2014 20:10:07 -0500 Received: from regular1.263xmail.com ([211.150.99.135]:54995 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754456AbaKSBKE (ORCPT ); Tue, 18 Nov 2014 20:10:04 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: boris.brezillon@free-electrons.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <420251a43b18a7039c972b940691d778> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <546BEDD9.1000205@rock-chips.com> Date: Wed, 19 Nov 2014 09:09:45 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Boris Brezillon , heiko@sntech.de, David Airlie , Rob Clark , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Grant Likely , Greg Kroah-Hartman , John Stultz , Rom Lemarchand , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-api@vger.kernel.org, linux-rockchip@lists.infradead.org, dianders@chromium.org, marcheu@chromium.org, dbehr@chromium.org, olof@lixom.net, djkurtz@chromium.org, cf@rock-chips.com, xxm@rock-chips.com, huangtao@rock-chips.com, kever.yang@rock-chips.com, yxj@rock-chips.com, xw@rock-chips.com Subject: Re: [PATCH v12 1/3] drm: rockchip: Add basic drm driver References: <1416297587-18959-1-git-send-email-mark.yao@rock-chips.com> <1416297629-19024-1-git-send-email-mark.yao@rock-chips.com> <20141118083234.GZ25711@phenom.ffwll.local> <20141118142130.6c12ab50@bbrezillon> <20141118142447.GC25711@phenom.ffwll.local> In-Reply-To: <20141118142447.GC25711@phenom.ffwll.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014年11月18日 22:24, Daniel Vetter wrote: > On Tue, Nov 18, 2014 at 02:21:30PM +0100, Boris Brezillon wrote: >> Hi Daniel, >> >> On Tue, 18 Nov 2014 09:32:34 +0100 >> Daniel Vetter wrote: >> >>> On Tue, Nov 18, 2014 at 04:00:29PM +0800, Mark Yao wrote: >>>> From: Mark yao >>>> >>>> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >>>> >>>> Signed-off-by: Mark Yao >>>> Signed-off-by: Daniel Kurtz >>>> Acked-by: Daniel Vetter >>>> Reviewed-by: Rob Clark >>>> --- >>>> Changes in v2: >>>> - use the component framework to defer main drm driver probe >>>> until all VOP devices have been probed. >>>> - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by >>>> master device and each vop device can shared the drm dma mapping. >>>> - use drm_crtc_init_with_planes and drm_universal_plane_init. >>>> - remove unnecessary middle layers. >>>> - add cursor set, move funcs to rockchip drm crtc. >>>> - use vop reset at first init >>>> - reference framebuffer when used and unreference when swap out vop >>>> >>>> Changes in v3: >>>> - change "crtc->fb" to "crtc->primary-fb" >>>> Adviced by Daniel Vetter >>>> - init cursor plane with universal api, remove unnecessary cursor set,move >>>> >>>> Changes in v4: >>>> Adviced by David Herrmann >>>> - remove drm_platform_*() usage, use register drm device directly. >>> Minor fixup for that part below. >>> >>> [snip] >>> >>>> +static int rockchip_drm_bind(struct device *dev) >>>> +{ >>>> + struct drm_device *drm; >>>> + int ret; >>>> + >>>> + drm = drm_dev_alloc(&rockchip_drm_driver, dev); >>>> + if (!drm) >>>> + return -ENOMEM; >>>> + >>>> + ret = drm_dev_set_unique(drm, "%s", dev_name(dev)); >>>> + if (ret) >>>> + goto err_free; >>> Please call rockchip_drm_load here directly and don't put it as the ->load >>> function into the driver vtable. The point of the alloc/register split is >>> that the driver can be completely set up _before_ we register anything. >>> But for backwards compat and historical reasons ->load is called somewhere >>> in the middle (so that you could access the minor nodes if needed, since >>> some drivers do that). >> I tried to do the same in the atmel-hlcdc DRM driver, but I need the >> primary drm_minor to register the connectors (see this kernel >> backtrace [1]), which means I either initialize the connector in the >> wrong place (currently part of the drm load process), or I just can't >> call atmel_hlcdc_dc_load before registering the drm device... > Hm right, wonder who that works with rockchip tbh. > > We did split up the drm_connector setup into _init and register, so if you > want to do this then you need to move the call to drm_connector_register > below the call to drm_dev_register. > > We should probably have a drm_connectors_register_all helper which does > this for all connectors on the connector list. And also grabs the > appropriate lock. > > I guess it's somewhat obvious that no one yet actually tried this ;-) > -Daniel right, I re-test the driver with it, get the same problem with Boris. I should move drm_connector_register below the drm_dev_register.