From: Dirk Brandewie <dirk.brandewie@gmail.com>
To: Ethan Zhao <ethan.zhao@oracle.com>,
viresh.kumar@linaro.org, rjw@rjwysocki.net, corbet@lwn.net
Cc: dirk.j.brandewie@intel.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
ethan.kernel@gmail.com, joe.jin@oracle.com,
brian.maly@oracle.com
Subject: Re: [PATCH 1/3] intel_pstate: skip the driver if Sun server has ACPI _PPC method
Date: Wed, 19 Nov 2014 06:59:35 -0800 [thread overview]
Message-ID: <546CB057.7040902@intel.com> (raw)
In-Reply-To: <1416299826-15813-6-git-send-email-ethan.zhao@oracle.com>
On 11/18/2014 12:37 AM, Ethan Zhao wrote:
> Oracle Sun X86 servers have dynamic power capping capability that works via
> ACPI _PPC method etc, so skip loading this driver if Sun server has ACPI _PPC
> enabled.
>
> Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com>
> ---
> drivers/cpufreq/intel_pstate.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 27bb6d3..5498eb0 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -943,6 +943,21 @@ static bool intel_pstate_no_acpi_pss(void)
> return true;
> }
>
> +static bool intel_pstate_has_acpi_ppc(void)
> +{
> + int i;
> +
> + for_each_possible_cpu(i) {
> + struct acpi_processor *pr = per_cpu(processors, i);
> +
> + if (!pr)
> + continue;
> + if (acpi_has_method(pr->handle, "_PPC"))
> + return true;
> + }
> + return false;
> +}
> +
> struct hw_vendor_info {
> u16 valid;
> char oem_id[ACPI_OEM_ID_SIZE];
> @@ -952,6 +967,7 @@ struct hw_vendor_info {
> /* Hardware vendor-specific info that has its own power management modes */
> static struct hw_vendor_info vendor_info[] = {
> {1, "HP ", "ProLiant"},
> + {1, "ORACLE", ""},
> {0, "", ""},
> };
>
Does this apply to ALL oracle systems?
Is the presence or absense of the _PPC method configurable in the oracle BIOS?
> @@ -969,12 +985,16 @@ static bool intel_pstate_platform_pwr_mgmt_exists(void)
> !strncmp(hdr.oem_table_id, v_info->oem_table_id, ACPI_OEM_TABLE_ID_SIZE) &&
> intel_pstate_no_acpi_pss())
> return true;
> + if (!strncmp(hdr.oem_id, v_info->oem_id, ACPI_OEM_ID_SIZE) &&
> + intel_pstate_has_acpi_ppc())
> + return true;
> }
>
> return false;
> }
> #else /* CONFIG_ACPI not enabled */
> static inline bool intel_pstate_platform_pwr_mgmt_exists(void) { return false; }
> +static inline bool intel_pstate_has_acpi_ppc(void) { return false; }
> #endif /* CONFIG_ACPI */
>
> static int __init intel_pstate_init(void)
>
next prev parent reply other threads:[~2014-11-19 15:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 8:36 [PATCH 0/3] intel_pstate: allow to be built as module and handle Sun server power capping Ethan Zhao
2014-11-18 8:37 ` [PATCH 1/3] intel_pstate: skip the driver if Sun server has ACPI _PPC method Ethan Zhao
2014-11-19 20:22 ` Linda Knippers
2014-11-20 0:52 ` ethan
2014-11-20 16:50 ` Dirk Brandewie
2014-11-21 0:37 ` ethan zhao
2014-11-21 4:44 ` Linda Knippers
2014-11-24 1:41 ` ethan zhao
2014-11-24 15:54 ` Linda Knippers
2014-11-25 0:33 ` ethan
2014-11-18 8:37 ` [PATCH 2/3] intel_pstate: allow driver to be built as a module Ethan Zhao
2014-11-18 20:36 ` Rafael J. Wysocki
2014-11-18 8:37 ` [PATCH 3/3] intel_pstate: add module and kernel command line parameter to ignore ACPI _PPC Ethan Zhao
2014-11-18 8:37 ` [PATCH 0/3] intel_pstate: allow to be built as module and handle Sun server power capping Ethan Zhao
2014-11-18 8:37 ` [PATCH 1/3] intel_pstate: skip the driver if Sun server has ACPI _PPC method Ethan Zhao
2014-11-19 14:59 ` Dirk Brandewie [this message]
2014-11-20 1:07 ` ethan
2014-11-18 8:37 ` [PATCH 2/3] intel_pstate: allow driver to be built as a module Ethan Zhao
2014-11-19 18:58 ` Kristen Carlson Accardi
2014-11-20 1:01 ` ethan
2014-11-18 8:37 ` [PATCH 3/3] intel_pstate: add module and kernel command line parameter to ignore ACPI _PPC Ethan Zhao
2014-11-19 19:05 ` Kristen Carlson Accardi
2014-11-20 0:57 ` ethan
2014-11-20 21:23 ` Kristen Carlson Accardi
2014-11-21 3:07 ` Ethan Zhao
2014-11-21 5:00 ` Linda Knippers
2014-11-24 1:56 ` ethan zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546CB057.7040902@intel.com \
--to=dirk.brandewie@gmail.com \
--cc=brian.maly@oracle.com \
--cc=corbet@lwn.net \
--cc=dirk.j.brandewie@intel.com \
--cc=ethan.kernel@gmail.com \
--cc=ethan.zhao@oracle.com \
--cc=joe.jin@oracle.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).