From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756690AbaKSUeg (ORCPT ); Wed, 19 Nov 2014 15:34:36 -0500 Received: from mout.web.de ([212.227.15.3]:49214 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756132AbaKSUef (ORCPT ); Wed, 19 Nov 2014 15:34:35 -0500 Message-ID: <546CFECC.8020309@users.sourceforge.net> Date: Wed, 19 Nov 2014 21:34:20 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Kent Overstreet , Neil Brown , linux-bcache@vger.kernel.org CC: linux-raid@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH 1/1] bcache: Deletion of an unnecessary check before the function call "kobject_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+i23r35Y7gopum2I3ppdAT9Btj41IAi+rJ4x6jeQVfBl9QQgNQy csF7u2QDHJpqFxUQfCAPzemnVDNIhgEKHGDZAyreBFTnFrKQFQH0ysYtLKs806eU27ZlTA+ JZmh+fkGCjX0u04uQUUu/lFgyt1Ln6wLAjs8Qqn+QpJxKwgtlcbzqIKYxshQf2XlNM4u6Eb AKKXumAgJpjC7pNjGqqUA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 19 Nov 2014 21:25:39 +0100 The kobject_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/md/bcache/super.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index d4713d0..1443c55 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -2076,8 +2076,7 @@ static void bcache_exit(void) { bch_debug_exit(); bch_request_exit(); - if (bcache_kobj) - kobject_put(bcache_kobj); + kobject_put(bcache_kobj); if (bcache_wq) destroy_workqueue(bcache_wq); if (bcache_major) -- 2.1.3