From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932489AbaKSXqS (ORCPT ); Wed, 19 Nov 2014 18:46:18 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:54711 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756318AbaKSXqM (ORCPT ); Wed, 19 Nov 2014 18:46:12 -0500 X-AuditID: cbfee68f-f791c6d000004834-b6-546d2bc155ef Message-id: <546D2BC0.8020208@samsung.com> Date: Thu, 20 Nov 2014 08:46:08 +0900 From: Beomho Seo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-version: 1.0 To: Lee Jones Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, sameo@linux.intel.com, lee.jone@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, cw00.choi@samsung.com, geunsik.lim@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, beomho.seo@samsung.com Subject: Re: [PATCH v5 1/4] mfd: rt5033: Add Richtek RT5033 driver core. References: <1416372760-2090-1-git-send-email-beomho.seo@samsung.com> <1416372760-2090-2-git-send-email-beomho.seo@samsung.com> <20141119163702.GF1875@x1> In-reply-to: <20141119163702.GF1875@x1> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0hTYRju85ydHVfC51L7NshgFJWW5v2LTAKJDkGkJJER6NLDFN1cm5cE f0impaJON7sM8ZJozlbRlDSdoGKBziTT0shLhbdMnXkZFabtaJH/nvd9n+d5nxdemhCukWI6 XpHMqhTSRAklII0u/qqjHZ7yiGM3W0TYsvScj0s/T1B4aGWah0smrASu6Orj4WKDlsBFc1U8 vKbJpnDfrAHgknENia3mXoDHV18CbBu87YAHWsoovFzQBXDNUL8D1tx9TOLsti4+tuTzsKU1 Gd/TfqVOuTLGciNgBgoLHJgX+lE+Y3i4QjENdR6MqT6XYkbemymmvDucKWysB8yyyT1McFkQ HMsmxqeyKu+QaEHcVO0EpczyvL4y+ZbIBEOSPOBII+iPDLMbxBZ2Q2/GnlJ5QEALYQ1A+d9b ef9IC7/n+FuDBwDNZXWTW8U3gH7lrNonNO0EPdDwJxEnIOEBZKxcBxym4GFk1Q2SHHaFl9Cg sWyz7wSd0Q/tGMlJXeB+1DcXxFkS8COBym02iuPshgwqadBt8oWwHKCWomscdoQHUYvhEY/T Enas08m5NgH3oQbjPMH5IDhCo+rXi7ytPBDZtJ2buxDci0ztfw8WoY66YVID3PTbEun/u+q3 uVYCoh64ssoYpfqqTOXnpZbK1SkKmVdMktwE7E9hWZ8qagaj7Sc6AaSBZJfTzHxChJAnTVWn yztBgD1EMSF2jUmy/5EiOcrHL9AXB/gH+PkGHQ+U7HGqEv+8IIQyaTKbwLJKVhWlSklk1Z3A gXYUZ4JIi3Amz+zTsxo6vXwnS3gxLoQ+GVWbIYj39motnj9n8RbtCHc/Kzt961CsD2jQiZvO h822BmCtdWdv9Dt941JOWmpw4rT5SHN1o6CNz89N953stxaFfhmM0s6nPatYaPpwJvLJ/R5p h9RKXCmVWF/NmKe7F30rnamNtoKMGyYJqY6T+ngQKrX0D5yOXNkPAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGKsWRmVeSWpSXmKPExsVy+t9jAd2D2rkhBrdX8Vmc/rSN3WLqwyds Fte/PGe1mPTkPbPF/CPnWC0mrpzMbNH/ZiGrxZ8JrWwW516tZLSYdH8Ci8X7PWcYLe5/Pcpo 8e1KB5PF5V1z2Cw+9x5htFh6/SKTxYTpa1ksWvceYbc43c1qcXp3icWMyS/ZHEQ91sxbw+hx ua+XyWPnrLvsHiuXf2Hz2LxCy2PTqk42jzvX9rB5zDsZ6NG3ZRWjx+dNcgFcUQ2MNhmpiSmp RQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlALyoplCXmlAKFAhKL i5X07TBNCA1x07WAaYzQ9Q0JgusxMkADCWsYM54te8JW0Kxd8eXpJeYGxutKXYycHBICJhLv /r5hh7DFJC7cW8/WxcjFISSwiFHiTfNJFgjnNaPEr7avQFUcHLwCWhI3HkiCNLAIqEqsWfCP EcRmE9CUeD/lCguILSoQIXFlzRywOK+AoMSPyfdYQFpFBFQkzr0xBxnJLHCbWWLet29sIDXC Ah4SkzZPAasXEpjHKLGrvxDE5hRQl9i1cjUrSC8zkD1lSi5ImFlAXmLzmrfMExgFZiHZMAuh ahaSqgWMzKsYRVMLkguKk9JzDfWKE3OLS/PS9ZLzczcxgtPQM6kdjCsbLA4xCnAwKvHwvnib HSLEmlhWXJl7iFGCg1lJhJedMzdEiDclsbIqtSg/vqg0J7X4EKMp0P8TmaVEk/OBKTKvJN7Q 2MTMyNLI3NDCyNhcSZz3QKt1oJBAemJJanZqakFqEUwfEwenVANjwfHMt7Ui4clTp54S5r3r zhL1VqMoal1wfv49sYlC52ofts7LrA1Q3Kj8vMoi/5EoS6Do2+cXf82d8WyPSq6HbGdG/iyt fLkdn3enNV7/MdOR98z2V+6n/2pf5p8ccu7aWdcjrZ2z7NwfKOjunZZcLqY14am+cv/CC+qX VBdL1z3bYF511zFXiaU4I9FQi7moOBEAgfd9+lkDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/2014 01:37 AM, Lee Jones wrote: > On Wed, 19 Nov 2014, Beomho Seo wrote: > >> This patch adds a new driver for Richtek RT5033 driver. >> RT5033 is a Multifunction device which includes battery charger, fuel gauge, >> flash LED current source, LDO and synchronous Buck converter. It is interfaced >> to host controller using I2C interface. >> >> Cc: Samuel Ortiz >> Cc: Lee Jones >> Signed-off-by: Beomho Seo >> Acked-by: Chanwoo Choi >> --- >> Changes in v5 >> - Change possible built as a module. >> - Revise rt5033_dev mfd cell entry. >> - Fix incorrect typo. >> - Add module alias. >> >> Changes in v4 >> - none. >> >> Changes in v3 >> - Correct sentence errors. >> - Add author information the top of each drivers. >> - Remove unnecessary pre-initialise, struct member(rt5033->i2c) and blink. >> - Change some return check. >> - Use bool and of_match_ptr(). >> >> Changes in v2 >> - Remove volatile_reg callback. Because this driver not in use regmap cache. >> - Revmoe unnecessary subnode of_compatible. >> - Add define for set_high impedance mode of charger. >> --- >> drivers/mfd/Kconfig | 12 ++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/rt5033.c | 136 +++++++++++++++++++ >> include/linux/mfd/rt5033-private.h | 260 ++++++++++++++++++++++++++++++++++++ >> include/linux/mfd/rt5033.h | 62 +++++++++ >> 5 files changed, 471 insertions(+) >> create mode 100644 drivers/mfd/rt5033.c >> create mode 100644 include/linux/mfd/rt5033-private.h >> create mode 100644 include/linux/mfd/rt5033.h >> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >> index 72d3808..9c13170 100644 >> --- a/drivers/mfd/Kconfig >> +++ b/drivers/mfd/Kconfig >> @@ -618,6 +618,18 @@ config MFD_RTSX_PCI >> types of memory cards, such as Memory Stick, Memory Stick Pro, >> Secure Digital and MultiMediaCard. >> >> +config MFD_RT5033 >> + tristate "Richtek RT5033 Power Management IC" >> + depends on I2C=y >> + select MFD_CORE >> + select REGMAP_I2C >> + help >> + This driver provides for the Richtek RT5033 Power Management IC, >> + which includes the I2C driver and the Core APIs. This driver provides >> + common support for accessing the device. The device supports multiple >> + sub-devices like charger, fuel gauge, flash LED, current source, >> + LDO and Buck. >> + >> config MFD_RTSX_USB >> tristate "Realtek USB card reader" >> depends on USB >> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile >> index 53467e2..4059c24 100644 >> --- a/drivers/mfd/Makefile >> +++ b/drivers/mfd/Makefile >> @@ -176,6 +176,7 @@ obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o >> obj-$(CONFIG_MFD_MENF21BMC) += menf21bmc.o >> obj-$(CONFIG_MFD_HI6421_PMIC) += hi6421-pmic-core.o >> obj-$(CONFIG_MFD_DLN2) += dln2.o >> +obj-$(CONFIG_MFD_RT5033) += rt5033.o >> >> intel-soc-pmic-objs := intel_soc_pmic_core.o intel_soc_pmic_crc.o >> obj-$(CONFIG_INTEL_SOC_PMIC) += intel-soc-pmic.o >> diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c >> new file mode 100644 >> index 0000000..4d289b9 >> --- /dev/null >> +++ b/drivers/mfd/rt5033.c >> @@ -0,0 +1,136 @@ >> +/* >> + * MFD core driver for the Richtek RT5033. >> + * >> + * Copyright (C) 2014 Samsung Electronics, Co., Ltd. >> + * Author: Beomho Seo >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published bythe Free Software Foundation. >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +static const struct regmap_irq rt5033_irqs[] = { >> + { .mask = RT5033_PMIC_IRQ_BUCKOCP, }, >> + { .mask = RT5033_PMIC_IRQ_BUCKLV, }, >> + { .mask = RT5033_PMIC_IRQ_SAFELDOLV, }, >> + { .mask = RT5033_PMIC_IRQ_LDOLV, }, >> + { .mask = RT5033_PMIC_IRQ_OT, }, >> + { .mask = RT5033_PMIC_IRQ_VDDA_UV, }, >> +}; >> + >> +static const struct regmap_irq_chip rt5033_irq_chip = { >> + .name = "rt5033", >> + .status_base = RT5033_REG_PMIC_IRQ_STAT, >> + .mask_base = RT5033_REG_PMIC_IRQ_CTRL, >> + .mask_invert = true, >> + .num_regs = 1, >> + .irqs = rt5033_irqs, >> + .num_irqs = ARRAY_SIZE(rt5033_irqs), >> +}; >> + >> +static const struct mfd_cell rt5033_devs[] = { >> + { .name = "rt5033-regulator", }, >> + { .name = "rt5033-charger", .of_compatible = "richtek,rt5033-charger",}, >> + { .name = "rt5033-battery", .of_compatible = "richtek,rt5033-battery",}, >> +}; > > Perhaps I wasn't clear enough in my previous review -- sorry for > that. I only want to see the single entry on one line i.e. one with > .name, but no .of_compatible. I probably wouldn't have requested a > re-spin, but you have white space issues at the end of those two lines > too. > I will follow your previous review. I will only change the single entry on one line. You said that you wouldn't have requested a re-spin. But If fix white space issues at the end of those two lines, those over 80 characters. So I will defer to your previous review. I will fix it and send v6 patch soon. Thanks, Beomho Seo