From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757987AbaKUIVD (ORCPT ); Fri, 21 Nov 2014 03:21:03 -0500 Received: from mout.web.de ([212.227.15.3]:57236 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbaKUIVA (ORCPT ); Fri, 21 Nov 2014 03:21:00 -0500 Message-ID: <546EF5CC.1050308@users.sourceforge.net> Date: Fri, 21 Nov 2014 09:20:28 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "James E. J. Bottomley" , linux-scsi@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH 1/1] SCSI-libcxgbi: Deletion of an unnecessary check before the function call "dst_release" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+Z0RZfQnNM25T8enVyMVTtICuTkgcCA9Jujwj7r+G2iMlUBHiJQ FraDMO38GF30maf3mJEWIQkbrmEa5B3u64p02lqTgphp1TEoxw7Lxtw6rG+sE/wd0Blymq+ sJXE4EIfX2nWX4qS8N5RDZtA5E2GU7qEL/HGC5mOjRpWDo+3gFqTjaAFiQr/t3BInIvfcTi Nn75uoelmtIwWqGSmweOA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 21 Nov 2014 09:15:10 +0100 The dst_release() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/scsi/cxgbi/libcxgbi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c index addd1dd..95d2654 100644 --- a/drivers/scsi/cxgbi/libcxgbi.c +++ b/drivers/scsi/cxgbi/libcxgbi.c @@ -798,8 +798,7 @@ void cxgbi_sock_closed(struct cxgbi_sock *csk) return; if (csk->saddr.sin_port) sock_put_port(csk); - if (csk->dst) - dst_release(csk->dst); + dst_release(csk->dst); csk->cdev->csk_release_offload_resources(csk); cxgbi_sock_set_state(csk, CTP_CLOSED); cxgbi_inform_iscsi_conn_closing(csk); -- 2.1.3