From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751329AbaK2Pah (ORCPT ); Sat, 29 Nov 2014 10:30:37 -0500 Received: from mout.web.de ([212.227.17.12]:63833 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbaK2Pag (ORCPT ); Sat, 29 Nov 2014 10:30:36 -0500 Message-ID: <5479E693.3010200@users.sourceforge.net> Date: Sat, 29 Nov 2014 16:30:27 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: netdev@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH 1/1] net-ipvlan: Deletion of an unnecessary check before the function call "free_percpu" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:8VvC2cdNPi+cHv5cwfZBs0cWyhhzR1215SvEdjBMG/GQObBJod7 E9iLPbpyxnCi+gKezktFCHyc+GzFJpxh/1nVdQNOdRKtK7OBOF6+uDba17yvP1dUTIirxDP Bd5Y+TwnlzpeQdwXqyZ9tJk1myuFVw6HtSfzlfAfn+LGPVCL0OwkfI0tZjMzGA/kNN4Jrs8 Gvg4XFBang9hzOH+izdVA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 29 Nov 2014 16:23:20 +0100 The free_percpu() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ipvlan/ipvlan_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index 96b71b0..feb1853 100644 --- a/drivers/net/ipvlan/ipvlan_main.c +++ b/drivers/net/ipvlan/ipvlan_main.c @@ -125,8 +125,7 @@ static void ipvlan_uninit(struct net_device *dev) struct ipvl_dev *ipvlan = netdev_priv(dev); struct ipvl_port *port = ipvlan->port; - if (ipvlan->pcpu_stats) - free_percpu(ipvlan->pcpu_stats); + free_percpu(ipvlan->pcpu_stats); port->count -= 1; if (!port->count) -- 2.1.3