From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751394AbaK2QEH (ORCPT ); Sat, 29 Nov 2014 11:04:07 -0500 Received: from mout.web.de ([212.227.17.11]:52166 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbaK2QEF (ORCPT ); Sat, 29 Nov 2014 11:04:05 -0500 Message-ID: <5479EE6A.8080904@users.sourceforge.net> Date: Sat, 29 Nov 2014 17:03:54 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Alexander Viro , linux-fsdevel@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH 1/1] fs-namei: Deletion of an unnecessary check before the function call "iput" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:J8obHdp/C7HeZWqVu5Fgz3Lwuch5da0vpW9rmpuFuyIQ6jeTHLT 3CSzh0u5MhHCr6NDx8mrmr1Bnec4PY9Z6tkkGYkIfODdmcIggy7O59bZXgrzwbgjeCSyHNH WwT2ulHDutuqs5GcDtlvLO97oOruGGqDZyquZed9KIcGw2+4VChyP5nkRW+hlk2Gcozd2oP wkgt0mwq27ZP4QLudChFQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 29 Nov 2014 17:00:21 +0100 The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/namei.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index ca81416..ce69074 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3759,8 +3759,7 @@ exit2: dput(dentry); } mutex_unlock(&nd.path.dentry->d_inode->i_mutex); - if (inode) - iput(inode); /* truncate the inode here */ + iput(inode); /* truncate the inode here */ inode = NULL; if (delegated_inode) { error = break_deleg_wait(&delegated_inode); -- 2.1.3